-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Enable the no-lonely-if
ESLint rule
#16715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable the no-lonely-if
ESLint rule
#16715
Conversation
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/3d2de7b103ad20f/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/69c252ec9d03efa/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/3d2de7b103ad20f/output.txt Total script time: 25.22 mins
Image differences available at: http://54.241.84.105:8877/3d2de7b103ad20f/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/69c252ec9d03efa/output.txt Total script time: 36.90 mins
Image differences available at: http://54.193.163.58:8877/69c252ec9d03efa/reftest-analyzer.html#web=eq.log |
/botio lint |
From: Bot.io (Windows)ReceivedCommand cmd_lint from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/6a3729da432fafa/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_lint from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/0fe1b0073873e45/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/0fe1b0073873e45/output.txt Total script time: 1.21 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/6a3729da432fafa/output.txt Total script time: 11.93 mins
|
These changes were mostly done automatically, using `gulp lint --fix`, and only a few spots with comments needed manual tweaking; please see https://eslint.org/docs/latest/rules/no-lonely-if
d17897a
to
c018070
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you.
These changes were mostly done automatically, using
gulp lint --fix
, and only a few spots with comments needed manual tweaking; please see https://eslint.org/docs/latest/rules/no-lonely-if