Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ESM] Convert the external/builder/-folder to use standard modules #16669

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

Snuffleupagus
Copy link
Collaborator

Depends on PR #16668.

Copy link
Contributor

@timvandermeij timvandermeij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with a rebase and merge conflicts fixed; thanks!

@Snuffleupagus Snuffleupagus marked this pull request as ready for review July 11, 2023 09:42
@Snuffleupagus
Copy link
Collaborator Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/42c6cdfa4a0c39e/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/de2be6119dc0b4f/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/42c6cdfa4a0c39e/output.txt

Total script time: 24.58 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 16
  different first/second rendering: 1

Image differences available at: http://54.241.84.105:8877/42c6cdfa4a0c39e/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/de2be6119dc0b4f/output.txt

Total script time: 38.63 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 23

Image differences available at: http://54.193.163.58:8877/de2be6119dc0b4f/reftest-analyzer.html#web=eq.log

@Snuffleupagus Snuffleupagus merged commit 73d650a into mozilla:master Jul 11, 2023
@Snuffleupagus Snuffleupagus deleted the esm-builder branch July 11, 2023 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants