[Annotation] Use the clip-path property when an annotation has some quad points #16492

calixteman · 2023-05-30T10:38:55Z

This way it'll avoid to split a div in multiple divs having the same id (which is supposed to be unique).

Snuffleupagus

Have you successfully tested this locally, since according to the inline comment I'd really expect some breakage caused by these changes?

src/display/annotation_layer.js

Snuffleupagus · 2023-06-09T18:15:58Z

Please make sure that this passes all tests before I attempt to review this.

calixteman · 2023-06-09T18:45:38Z

/botio test

moz-tools-bot · 2023-06-09T18:45:40Z

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/5e0e508d378bef2/output.txt

moz-tools-bot · 2023-06-09T18:45:40Z

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/46a092fa4e835df/output.txt

moz-tools-bot · 2023-06-09T18:57:29Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/5e0e508d378bef2/output.txt

Total script time: 11.79 mins

Font tests: Passed
Unit tests: Passed
Integration Tests: FAILED
Regression tests: FAILED

  errors: 1644
  different ref/snapshot: 14
  different first/second rendering: 2

Image differences available at: http://54.241.84.105:8877/5e0e508d378bef2/reftest-analyzer.html#web=eq.log

moz-tools-bot · 2023-06-09T19:06:22Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/46a092fa4e835df/output.txt

Total script time: 20.68 mins

Font tests: Passed
Unit tests: Passed
Integration Tests: FAILED
Regression tests: FAILED

  errors: 822
  different ref/snapshot: 10
  different first/second rendering: 1

Image differences available at: http://54.193.163.58:8877/46a092fa4e835df/reftest-analyzer.html#web=eq.log

calixteman · 2023-06-09T21:15:52Z

/botio test

moz-tools-bot · 2023-06-09T21:15:54Z

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/1dfeaad664d07bc/output.txt

moz-tools-bot · 2023-06-09T21:15:54Z

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/e4f3021c49daf3f/output.txt

moz-tools-bot · 2023-06-09T21:16:06Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/1dfeaad664d07bc/output.txt

Total script time: 0.19 mins

moz-tools-bot · 2023-06-09T21:16:25Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/e4f3021c49daf3f/output.txt

Total script time: 0.48 mins

calixteman · 2023-06-09T21:34:45Z

/botio test

moz-tools-bot · 2023-06-09T21:34:47Z

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/7d6ff860c859e29/output.txt

moz-tools-bot · 2023-06-09T21:34:47Z

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/69b657972b649e5/output.txt

moz-tools-bot · 2023-06-09T21:59:18Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/69b657972b649e5/output.txt

Total script time: 24.50 mins

Font tests: Passed
Unit tests: Passed
Integration Tests: FAILED
Regression tests: FAILED

  different ref/snapshot: 33

Image differences available at: http://54.241.84.105:8877/69b657972b649e5/reftest-analyzer.html#web=eq.log

moz-tools-bot · 2023-06-09T22:08:28Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/7d6ff860c859e29/output.txt

Total script time: 33.68 mins

Font tests: Passed
Unit tests: Passed
Integration Tests: FAILED
Regression tests: FAILED

  different ref/snapshot: 30

Image differences available at: http://54.193.163.58:8877/7d6ff860c859e29/reftest-analyzer.html#web=eq.log

calixteman · 2023-06-21T20:21:50Z

/botio test

moz-tools-bot · 2023-06-21T20:21:52Z

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/6ba61507e168df6/output.txt

moz-tools-bot · 2023-06-21T20:21:52Z

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/9e5f52d134653f7/output.txt

moz-tools-bot · 2023-06-21T20:47:21Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/9e5f52d134653f7/output.txt

Total script time: 25.46 mins

Font tests: Passed
Unit tests: Passed
Integration Tests: FAILED
Regression tests: FAILED

  different ref/snapshot: 45

Image differences available at: http://54.241.84.105:8877/9e5f52d134653f7/reftest-analyzer.html#web=eq.log

moz-tools-bot · 2023-07-19T19:53:40Z

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/f2ad1288eba9121/output.txt

moz-tools-bot · 2023-07-19T20:18:28Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/f2ad1288eba9121/output.txt

Total script time: 24.78 mins

Font tests: Passed
Unit tests: Passed
Integration Tests: Passed
Regression tests: FAILED

  different ref/snapshot: 39
  different first/second rendering: 1

Image differences available at: http://54.241.84.105:8877/f2ad1288eba9121/reftest-analyzer.html#web=eq.log

moz-tools-bot · 2023-07-19T20:32:45Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/65b64ed3fad8a8d/output.txt

Total script time: 39.07 mins

Font tests: Passed
Unit tests: Passed
Integration Tests: FAILED
Regression tests: FAILED

  different ref/snapshot: 34
  different first/second rendering: 1

Image differences available at: http://54.193.163.58:8877/65b64ed3fad8a8d/reftest-analyzer.html#web=eq.log

calixteman · 2023-07-19T20:47:12Z

I had to add a small delay to make it working locally (it was working previously locally with no delay).
/botio test

moz-tools-bot · 2023-07-19T20:47:14Z

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/89a508f47c13d55/output.txt

moz-tools-bot · 2023-07-19T20:47:14Z

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/d3dbfb7c911a23b/output.txt

moz-tools-bot · 2023-07-19T21:12:33Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/89a508f47c13d55/output.txt

Total script time: 25.31 mins

Font tests: Passed
Unit tests: Passed
Integration Tests: FAILED
Regression tests: FAILED

  different ref/snapshot: 38
  different first/second rendering: 2

Image differences available at: http://54.241.84.105:8877/89a508f47c13d55/reftest-analyzer.html#web=eq.log

moz-tools-bot · 2023-07-19T21:26:03Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/d3dbfb7c911a23b/output.txt

Total script time: 38.81 mins

Font tests: Passed
Unit tests: Passed
Integration Tests: FAILED
Regression tests: FAILED

  different ref/snapshot: 33

Image differences available at: http://54.193.163.58:8877/d3dbfb7c911a23b/reftest-analyzer.html#web=eq.log

src/display/annotation_layer.js

…uad points This way it'll avoid to split a div in multiple divs having the same id (which is supposed to be unique).

Snuffleupagus · 2023-07-20T09:22:20Z

/botio-linux preview

moz-tools-bot · 2023-07-20T09:22:22Z

From: Bot.io (Linux m4)

Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/fc9b82f6d53f804/output.txt

moz-tools-bot · 2023-07-20T09:23:47Z

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/fc9b82f6d53f804/output.txt

Total script time: 1.41 mins

Published

Viewer: http://54.241.84.105:8877/fc9b82f6d53f804/web/viewer.html
Viewer (legacy): http://54.241.84.105:8877/fc9b82f6d53f804/legacy/web/viewer.html

Snuffleupagus · 2023-07-20T09:41:18Z

For the quadpoints.pdf document, looking both at the test-results and comparing the rendering in the viewer with/without this patch, it does feel that the linkAnnotation border is now slightly thinner. Can this be improved somehow, or is it perhaps some kind of rounding issue that we can't control?

calixteman · 2023-07-20T09:57:48Z

For the quadpoints.pdf document, looking both at the test-results and comparing the rendering in the viewer with/without this patch, it does feel that the linkAnnotation border is now slightly thinner. Can this be improved somehow, or is it perhaps some kind of rounding issue that we can't control?

It seems to depend on the zoom factor and with my screen (and my eyes), I've the impress that it's sometimes slightly thinner without the patch and sometimes slightly thinner with... it depends. So yes, you're likely right, it's probably due to rounding issues.
Maybe we can mitigate this in adding 0.5 to the border size.
It seems to me that having a border on a link is a rare case, so I wouldn't worry that much about that.

Snuffleupagus · 2023-07-20T10:46:28Z

So yes, you're likely right, it's probably due to rounding issues.
Maybe we can mitigate this in adding 0.5 to the border size.

Let's just leave this as-is for now then, but keep our eyes out for any potential regressions.

It seems to me that having a border on a link is a rare case, so I wouldn't worry that much about that.

I'd say that it's somewhat common actually, since many LaTeX-generated PDF documents use linkAnnotation borders. However it's not particularly common for those links to be split e.g. across lines, which means that the border-related changes in this patch won't affect things in the "normal" case.

Snuffleupagus

r=me, with a final round of testing; thank you!

calixteman · 2023-07-20T12:01:33Z

/botio test

moz-tools-bot · 2023-07-20T12:01:35Z

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/6f101ba111e1d1d/output.txt

moz-tools-bot · 2023-07-20T12:01:36Z

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/6cc8eb7fcf2468f/output.txt

moz-tools-bot · 2023-07-20T12:27:06Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/6f101ba111e1d1d/output.txt

Total script time: 25.50 mins

Font tests: Passed
Unit tests: Passed
Integration Tests: FAILED
Regression tests: FAILED

  different ref/snapshot: 36
  different first/second rendering: 3

Image differences available at: http://54.241.84.105:8877/6f101ba111e1d1d/reftest-analyzer.html#web=eq.log

moz-tools-bot · 2023-07-20T12:37:10Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/6cc8eb7fcf2468f/output.txt

Total script time: 35.55 mins

Font tests: Passed
Unit tests: FAILED
Integration Tests: FAILED
Regression tests: FAILED

  different ref/snapshot: 36

Image differences available at: http://54.193.163.58:8877/6cc8eb7fcf2468f/reftest-analyzer.html#web=eq.log

calixteman · 2023-07-20T13:01:36Z

/botio makeref

moz-tools-bot · 2023-07-20T13:01:38Z

From: Bot.io (Windows)

Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/2c0a049dcfa3838/output.txt

moz-tools-bot · 2023-07-20T13:01:38Z

From: Bot.io (Linux m4)

Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/a72357aa310f331/output.txt

moz-tools-bot · 2023-07-20T13:22:28Z

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/a72357aa310f331/output.txt

Total script time: 20.81 mins

Lint: Passed
Make references: Passed
Check references: Passed

moz-tools-bot · 2023-07-20T13:27:27Z

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/2c0a049dcfa3838/output.txt

Total script time: 25.79 mins

Lint: Passed
Make references: Passed
Check references: Passed

calixteman added the annotations label May 30, 2023

calixteman requested a review from Snuffleupagus May 30, 2023 10:38

Snuffleupagus requested changes May 30, 2023

View reviewed changes

src/display/annotation_layer.js Outdated Show resolved Hide resolved

calixteman force-pushed the clip_path branch 2 times, most recently from 49b5145 to 893608a Compare May 30, 2023 12:53

calixteman force-pushed the clip_path branch from 893608a to 5ec5018 Compare June 9, 2023 17:49

calixteman requested a review from Snuffleupagus June 9, 2023 17:53

calixteman force-pushed the clip_path branch from 5ec5018 to 5f4e805 Compare June 9, 2023 21:15

calixteman marked this pull request as draft June 15, 2023 09:55

calixteman force-pushed the clip_path branch from 5f4e805 to 1d2cdbd Compare June 21, 2023 20:21

calixteman force-pushed the clip_path branch from eaa09e6 to c49b287 Compare July 19, 2023 20:46

Snuffleupagus reviewed Jul 20, 2023

View reviewed changes

src/display/annotation_layer.js Outdated Show resolved Hide resolved

[Annotation] Use the clip-path property when an annotation has some q…

8daf2f1

…uad points This way it'll avoid to split a div in multiple divs having the same id (which is supposed to be unique).

calixteman force-pushed the clip_path branch from c49b287 to 8daf2f1 Compare July 20, 2023 08:53

Snuffleupagus approved these changes Jul 20, 2023

View reviewed changes

calixteman merged commit 0702663 into mozilla:master Jul 20, 2023

[Annotation] Use the clip-path property when an annotation has some quad points #16492

[Annotation] Use the clip-path property when an annotation has some quad points #16492

Conversation

calixteman commented May 30, 2023

Snuffleupagus left a comment

Choose a reason for hiding this comment

Snuffleupagus commented Jun 9, 2023

calixteman commented Jun 9, 2023

moz-tools-bot commented Jun 9, 2023

From: Bot.io (Linux m4)

Received

moz-tools-bot commented Jun 9, 2023

From: Bot.io (Windows)

Received

moz-tools-bot commented Jun 9, 2023

From: Bot.io (Linux m4)

Failed

moz-tools-bot commented Jun 9, 2023

From: Bot.io (Windows)

Failed

calixteman commented Jun 9, 2023

moz-tools-bot commented Jun 9, 2023

From: Bot.io (Linux m4)

Received

moz-tools-bot commented Jun 9, 2023

From: Bot.io (Windows)

Received

moz-tools-bot commented Jun 9, 2023

From: Bot.io (Linux m4)

Failed

moz-tools-bot commented Jun 9, 2023

From: Bot.io (Windows)

Failed

calixteman commented Jun 9, 2023

moz-tools-bot commented Jun 9, 2023

From: Bot.io (Windows)

Received

moz-tools-bot commented Jun 9, 2023

From: Bot.io (Linux m4)

Received

moz-tools-bot commented Jun 9, 2023

From: Bot.io (Linux m4)

Failed

moz-tools-bot commented Jun 9, 2023

From: Bot.io (Windows)

Failed

calixteman commented Jun 21, 2023

moz-tools-bot commented Jun 21, 2023

From: Bot.io (Windows)

Received

moz-tools-bot commented Jun 21, 2023

From: Bot.io (Linux m4)

Received

moz-tools-bot commented Jun 21, 2023

From: Bot.io (Linux m4)

Failed

moz-tools-bot commented Jul 19, 2023

From: Bot.io (Linux m4)

Received

moz-tools-bot commented Jul 19, 2023

From: Bot.io (Linux m4)

Failed

moz-tools-bot commented Jul 19, 2023

From: Bot.io (Windows)

Failed

calixteman commented Jul 19, 2023

moz-tools-bot commented Jul 19, 2023

From: Bot.io (Linux m4)

Received

moz-tools-bot commented Jul 19, 2023

From: Bot.io (Windows)

Received

moz-tools-bot commented Jul 19, 2023

From: Bot.io (Linux m4)

Failed

moz-tools-bot commented Jul 19, 2023

From: Bot.io (Windows)

Failed

Snuffleupagus commented Jul 20, 2023

moz-tools-bot commented Jul 20, 2023

Snuffleupagus commented Jul 20, 2023 •

edited

Loading