Remove the SystemJS dependency from the web/preferences.js file
#11911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snuffleupagus
force-pushed
the
getDefaultPreferences-rm-SystemJS
branch
from
9e0a40e to
bf75b2b
Compare
Originally the `default_preferences.json` file was checked into the repository, and we thus needed to load it in non-PRODUCTION mode (which was originally done asynchronously using `XMLHttpRequest`). Over the years a lot has changed and the `default_preferences.json` file is now built, by the `gulp default_preferences` task, from the `web/app_options.js` file. Hence it's no longer necessary, in non-PRODUCTION mode, to use SystemJS here since we can simply use a standard `import` statement instead. Note how e.g. `web/app.js` already imports from `web/app_options.js` in the same exact way that `web/preferences.js` now does, hence this patch will *not* result in any significant changes in the built/bundled viewer file. This is another (small) part in trying to reduce usage of SystemJS, with the goal of hopefully getting rid of it completely. (I've started working on this, and doing so has identified a number of problem areas; this patch addresses one of them.)
Snuffleupagus
force-pushed
the
getDefaultPreferences-rm-SystemJS
branch
from
bf75b2b to
8f24415
Compare
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/616bc0b4b6d04cf/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/616bc0b4b6d04cf/output.txt Total script time: 3.28 mins Published |
timvandermeij
approved these changes
May 16, 2020
|
Nice find; thank you for working on reducing SystemJS usage! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally the
default_preferences.jsonfile was checked into the repository, and we thus needed to load it in non-PRODUCTION mode (which was originally done asynchronously usingXMLHttpRequest). Over the years a lot has changed and thedefault_preferences.jsonfile is now built, by thegulp default_preferencestask, from theweb/app_options.jsfile. Hence it's no longer necessary, in non-PRODUCTION mode, to use SystemJS here since we can simply use a standardimportstatement instead.Note how e.g.
web/app.jsalready imports fromweb/app_options.jsin the same exact way thatweb/preferences.jsnow does, hence this patch will not result in any significant changes in the built/bundled viewer file.This is another (small) part in trying to reduce usage of SystemJS, with the goal of hopefully getting rid of it completely. (I've started working on this, and doing so has identified a number of problem areas; this patch addresses one of them.)