Handle errors individually for each annotation in the _parsedAnnotations getter
#11889
Conversation
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/26ef446ad999889/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/4910e03c96f9601/output.txt |
…ions` getter While working on PR 11872, it occurred to me that it probably wouldn't be a bad idea to change the `_parsedAnnotations` getter to handle errors individually for each annotation. This way, one broken/corrupt annotation won't prevent the rest of them from being e.g. fetched through the API.
Snuffleupagus
force-pushed
the
_parsedAnnotations-move-catch
branch
from
c2a5c2c to
73636e0
Compare
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/26ef446ad999889/output.txt Total script time: 25.72 mins
Image differences available at: http://54.67.70.0:8877/26ef446ad999889/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.215.176.217:8877/4910e03c96f9601/output.txt Total script time: 29.70 mins
Image differences available at: http://54.215.176.217:8877/4910e03c96f9601/reftest-analyzer.html#web=eq.log |
|
/botio-linux test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/4bb972b8e77911f/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/4bb972b8e77911f/output.txt Total script time: 25.79 mins
Image differences available at: http://54.67.70.0:8877/4bb972b8e77911f/reftest-analyzer.html#web=eq.log |
|
Looks good; thanks! |
While working on PR #11872, it occurred to me that it probably wouldn't be a bad idea to change the
_parsedAnnotationsgetter to handle errors individually for each annotation. This way, one broken/corrupt annotation won't prevent the rest of them from being e.g. fetched through the API.