Attempt to respect the "zoom" hash parameter, even when the "nameddest" parameter is present (issue 11875) #11880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t" parameter is present (issue 11875) Given that the `PDFLinkService.setHash` method itself if completely synchronous, moving the handling of "nameddest" to occur last *shouldn't* cause any problems (famous last words). This way the destination will still override any previous parameter, such as e.g. the "page", as expected. Furthermore, given that the `PDFLinkService.navigateTo` method is asynchronous that should provide additional guarantees that the "nameddest" parameter is always respected. As sort-of expected, this fairly innocent looking change also required some tweaks in the `PDFHistory` to prevent dummy history entires upon document load (only an issue when both "page" *and* "nameddest" parameters are provided in the hash).
Snuffleupagus
changed the title
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/3ca0793c6d9f391/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/3ca0793c6d9f391/output.txt Total script time: 3.29 mins Published |
timvandermeij
approved these changes
May 8, 2020
|
Thank you for improving this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that the
PDFLinkService.setHashmethod itself if completely synchronous, moving the handling of "nameddest" to occur last shouldn't cause any problems (famous last words).This way the destination will still override any previous parameter, such as e.g. the "page", as expected. Furthermore, given that the
PDFLinkService.navigateTomethod is asynchronous that should provide additional guarantees that the "nameddest" parameter is always respected.As sort-of expected, this fairly innocent looking change also required some tweaks in the
PDFHistoryto prevent dummy history entires upon document load (only an issue when both "page" and "nameddest" parameters are provided in the hash).Fixes #11875