Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the ESLint grouped-accessor-pairs rule #11879

Merged

Conversation

Snuffleupagus
Copy link
Collaborator

This rule complements the existing accessor-pairs nicely, and ensures that a getter/setter pair is always consistently ordered.

Please find additional details about this rule at https://eslint.org/docs/rules/grouped-accessor-pairs

This rule complements the existing `accessor-pairs` nicely, and ensures that a getter/setter pair is always consistently ordered.

Please find additional details about this rule at https://eslint.org/docs/rules/grouped-accessor-pairs
@Snuffleupagus
Copy link
Collaborator Author

/botio lint

@pdfjsbot
Copy link

pdfjsbot commented May 7, 2020

From: Bot.io (Windows)


Received

Command cmd_lint from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.215.176.217:8877/f07609f334daa5a/output.txt

@pdfjsbot
Copy link

pdfjsbot commented May 7, 2020

From: Bot.io (Linux m4)


Received

Command cmd_lint from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.67.70.0:8877/f74e39ee2c359db/output.txt

@pdfjsbot
Copy link

pdfjsbot commented May 7, 2020

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/f74e39ee2c359db/output.txt

Total script time: 1.98 mins

  • Lint: Passed

@pdfjsbot
Copy link

pdfjsbot commented May 7, 2020

From: Bot.io (Windows)


Success

Full output at http://54.215.176.217:8877/f07609f334daa5a/output.txt

Total script time: 2.53 mins

  • Lint: Passed

@timvandermeij timvandermeij merged commit 9c341cf into mozilla:master May 7, 2020
@timvandermeij
Copy link
Contributor

Nice improvement!

@Snuffleupagus Snuffleupagus deleted the eslint-grouped-accessor-pairs branch May 7, 2020 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants