Use the ESLint no-restricted-syntax rule to ensure that assert is always called with two arguments
#11873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… always called with two arguments Having `assert` calls without a message string isn't very helpful when debugging, and it turns out that it's easy enough to make use of ESLint to enforce better `assert` call-sites. In a couple of cases the `assert` calls were changed to "regular" throwing of errors instead, since that seemed more appropriate. Please find additional details about the ESLint rule at https://eslint.org/docs/rules/no-restricted-syntax
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/f340ae181b4b5ef/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/cb78b79b7ab60d2/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/f340ae181b4b5ef/output.txt Total script time: 25.60 mins
Image differences available at: http://54.67.70.0:8877/f340ae181b4b5ef/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.215.176.217:8877/cb78b79b7ab60d2/output.txt Total script time: 28.50 mins
Image differences available at: http://54.215.176.217:8877/cb78b79b7ab60d2/reftest-analyzer.html#web=eq.log |
timvandermeij
approved these changes
May 7, 2020
|
Looks like a useful addition to me. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having
assertcalls without a message string isn't very helpful when debugging, and it turns out that it's easy enough to make use of ESLint to enforce betterassertcall-sites.In a couple of cases the
assertcalls were changed to "regular" throwing of errors instead, since that seemed more appropriate.Please find additional details about the ESLint rule at https://eslint.org/docs/rules/no-restricted-syntax