Remove the create-react-app example (issue 11729)
#11864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given that none of the PDF.js contributors know React, maintaining and/or providing supporting for the example isn't really feasible unfortunately. Even something as simple as running/testing the example becomes difficult for anyone completely unfamiliar with React, and furthermore: - It's very difficult to tell if the example demonstrates React best-practices, since the PDF.js contributors don't know React. - We also have no reasonable way of keeping the example up-to-date with changes in React. - The React example, in its current form, is even *hard-coding* the PDF.js version to a now unsupported version. - The example is currently triggering "fake worker" usage, see issue 11729, which is really *really* bad. Note that the "fake worker" functionality is *only* intended as a fallback, and it should absolutely *not* under any circumstances be advertised and certainly shouldn't be triggered in official PDF.js examples.
timvandermeij
approved these changes
May 1, 2020
|
I can only agree with this, and will make sure to be more critical about adding such examples in the future. Thanks! |
Don't worry about that, it was worth a try adding a new example :-) (Given that the relevant issue had been open for over a month, with no-one attempting to fix the example, I thus figured that submitting this patch made sense.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that none of the PDF.js contributors know React, maintaining and/or providing supporting for the example isn't really feasible unfortunately.
Even something as simple as running/testing the example becomes difficult for anyone completely unfamiliar with React, and furthermore:
It's very difficult to tell if the example demonstrates React best-practices, since the PDF.js contributors don't know React.
We also have no reasonable way of keeping the example up-to-date with changes in React.
The React example, in its current form, is even hard-coding the PDF.js version to a now unsupported version.
The example is currently triggering "fake worker" usage, see issue 11729, which is really really bad. Note that the "fake worker" functionality is only intended as a fallback, and it should absolutely not under any circumstances be advertised and certainly shouldn't be triggered in official PDF.js examples.
Fixes #11729