Add more categories of unsupported features. #11863
Conversation
brendandahl
force-pushed
the
unsupported-features
branch
from
cb44764 to
79fca62
Compare
| @@ -294,6 +294,18 @@ const UNSUPPORTED_FEATURES = { | |||
| smask: "smask", | |||
| shadingPattern: "shadingPattern", | |||
| font: "font", | |||
There was a problem hiding this comment.
Assuming that the font key is actually unused now, should it be removed?
The same question also applies for the unknown key above.
There was a problem hiding this comment.
These are exposed on the API, so I'll just mark them as @deprecated for now,
There was a problem hiding this comment.
These are exposed on the API,
That's certainly true, but considering that nothing (in the PDF.js code) actually uses them now I just wondered what good they do for an API user at this point!?
Anyway, it doesn't matter much either way here and the patch looks good as-is :-)
brendandahl
force-pushed
the
unsupported-features
branch
from
79fca62 to
5bea7e4
Compare
| @@ -294,6 +294,18 @@ const UNSUPPORTED_FEATURES = { | |||
| smask: "smask", | |||
| shadingPattern: "shadingPattern", | |||
| font: "font", | |||
There was a problem hiding this comment.
These are exposed on the API,
That's certainly true, but considering that nothing (in the PDF.js code) actually uses them now I just wondered what good they do for an API user at this point!?
Anyway, it doesn't matter much either way here and the patch looks good as-is :-)
|
/botio unittest |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @timvandermeij received. Current queue size: 0 Live output at: http://54.215.176.217:8877/542f32ae5756071/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/c295a37fe6b30c3/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/c295a37fe6b30c3/output.txt Total script time: 3.59 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/542f32ae5756071/output.txt Total script time: 4.58 mins
|
brendandahl
force-pushed
the
unsupported-features
branch
from
5bea7e4 to
b1be33c
Compare
|
Thank you! |
Fixes #11815
For non-generic missing features that are errors I've prefixed them with "error."