Move the maybeValidDimensions check, used with JPEG images, to occur earlier (PR 11523 follow-up)
#11847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r earlier (PR 11523 follow-up)
Given that the `NativeImageDecoder.{isSupported, isDecodable}` methods require both dictionary lookups *and* ColorSpace parsing, in hindsight it actually seems more reasonable to the `JpegStream.maybeValidDimensions` checks *first*.
Snuffleupagus
force-pushed
the
move-maybeValidDimensions
branch
from
bdb0577 to
911c33f
Compare
Snuffleupagus
changed the title
maybeValidDimension check, used with JPEG images, to occur earlier (PR 11523 follow-up)maybeValidDimensions check, used with JPEG images, to occur earlier (PR 11523 follow-up)
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/a4551179b28cfac/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/3461d0422d0d678/output.txt |
From: Bot.io (Windows)FailedFull output at http://54.215.176.217:8877/a4551179b28cfac/output.txt Total script time: 25.01 mins
Image differences available at: http://54.215.176.217:8877/a4551179b28cfac/reftest-analyzer.html#web=eq.log |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/3461d0422d0d678/output.txt Total script time: 60.00 mins |
timvandermeij
approved these changes
Apr 26, 2020
|
Good idea! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that the
NativeImageDecoder.{isSupported, isDecodable}methods require both dictionary lookups and ColorSpace parsing, in hindsight it actually seems more reasonable to theJpegStream.maybeValidDimensionschecks first.