Always attempt to dispatch the "webviewerloaded" event at the embedding document (PR 10318 follow-up, issue 11829)
#11837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Snuffleupagus
force-pushed
the
webviewerloaded-top
branch
2 times, most recently
from
116ff4a to
2ef9f6e
Compare
…ng `document` (PR 10318 follow-up, issue 11829) This is necessary in order to support cases where the default viewer is embedded in a *dynamically* created <iframe> element. In order to also support a use-case where there's *multiple* <iframe> elements (containing default viewers) on the same page, the "webviewerloaded" event now includes a `source` detail parameter such that it's possible to associate an event with the relevant DOM element.
Snuffleupagus
force-pushed
the
webviewerloaded-top
branch
from
2ef9f6e to
479173c
Compare
Snuffleupagus
changed the title
document (PR 10318 follow-up, issue 11829)document (PR 10318 follow-up, issue 11829)up, issue 11829)
Snuffleupagus
changed the title
document (PR 10318 follow-up, issue 11829)up, issue 11829)document (PR 10318 follow-up, issue 11829)
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/c77f8d306a23503/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/c77f8d306a23503/output.txt Total script time: 2.56 mins Published |
timvandermeij
approved these changes
Apr 23, 2020
|
Thank you for improving this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary in order to support cases where the default viewer is embedded in a dynamically created <iframe> element.
In order to also support a use-case where there's multiple <iframe> elements (containing default viewers) on the same page, the "webviewerloaded" event now includes a
sourcedetail parameter such that it's possible to associate an event with the relevant DOM element.Fixes #11829