Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[src/core/jpg.js] Remove redundant marker validation at the end of the decodeScan function (PR 11805 follow-up) #11819

Conversation

Snuffleupagus
Copy link
Collaborator

With the MCU parsing changes made in PR #11805, the final marker validation is no longer necessary before the decodeScan function returns.

…e `decodeScan` function (PR 11805 follow-up)

With the MCU parsing changes made in PR 11805, the final marker validation is no longer necessary before the `decodeScan` function returns.
@Snuffleupagus
Copy link
Collaborator Author

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.67.70.0:8877/a97a14c31261087/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.215.176.217:8877/1b2336bc9737f9a/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Failed

Full output at http://54.67.70.0:8877/a97a14c31261087/output.txt

Total script time: 60.00 mins

@pdfjsbot
Copy link

From: Bot.io (Windows)


Failed

Full output at http://54.215.176.217:8877/1b2336bc9737f9a/output.txt

Total script time: 60.00 mins

@timvandermeij
Copy link
Contributor

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/c1c9e649722a754/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://54.215.176.217:8877/dca79029dcca76b/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Failed

Full output at http://54.215.176.217:8877/dca79029dcca76b/output.txt

Total script time: 1.80 mins

  • Font tests: FAILED
  • Unit tests: FAILED
  • Regression tests: FAILED

Image differences available at: http://54.215.176.217:8877/dca79029dcca76b/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Failed

Full output at http://54.67.70.0:8877/c1c9e649722a754/output.txt

Total script time: 19.82 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://54.67.70.0:8877/c1c9e649722a754/reftest-analyzer.html#web=eq.log

@timvandermeij timvandermeij merged commit c1733d2 into mozilla:master Apr 17, 2020
@timvandermeij
Copy link
Contributor

Let's do this; thanks!

@Snuffleupagus Snuffleupagus deleted the decodeScan-rm-findNextFileMarker-call branch April 18, 2020 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants