Update the "gulp jsdoc" task to account for API changes in the mkdirp package (PR 11772 follow-up)
#11781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p` package (PR 11772 follow-up) I completely overlooked the fact that we had *one* occurrence of an asynchronous `mkdirp` call in the gulpfile, which thus breaks since the package now uses Promises rather than a callback function; sorry about that!
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/93ccac7d7f3cd80/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/93ccac7d7f3cd80/output.txt Total script time: 2.45 mins Published |
timvandermeij
approved these changes
Apr 5, 2020
|
Thank you for the follow-up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I completely overlooked the fact that we had one occurrence of an asynchronous
mkdirpcall in the gulpfile, which thus breaks since the package now uses Promises rather than a callback function; sorry about that!