Replace the RTL images with CSS transforms of the standard images (issue 11766) #11767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/63b3f22aba65d5f/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/63b3f22aba65d5f/output.txt Total script time: 2.40 mins Published |
…sue 11766) This avoids unnecessary duplication of many images, thus reducing the size of PDF.js image resources slightly. Note that since the images should only be flipped horizontally, this required specifying the horizontal/vertical scaling separately for the hiDPI-images.
Snuffleupagus
force-pushed
the
issue-11766
branch
from
013e498 to
63efe61
Compare
timvandermeij
approved these changes
Mar 30, 2020
|
Nice work! Aside from a reduction in image resources, this also makes the viewer easier to restyle, both for us and for third-party usage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids unnecessary duplication of many images, thus reducing the size of PDF.js image resources slightly.
Note that since the images should only be flipped horizontally, this required specifying the horizontal/vertical scaling separately for the hiDPI-images.
Fixes #11766