-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the unused sizes
and encoding
properties on Font
instances
#11755
Remove the unused sizes
and encoding
properties on Font
instances
#11755
Conversation
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/8b88c55c2a98d5d/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/e156c14842eed0f/output.txt |
From: Bot.io (Windows)FailedFull output at http://54.215.176.217:8877/e156c14842eed0f/output.txt Total script time: 1.78 mins
Image differences available at: http://54.215.176.217:8877/e156c14842eed0f/reftest-analyzer.html#web=eq.log |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/8b88c55c2a98d5d/output.txt Total script time: 19.72 mins
Image differences available at: http://54.67.70.0:8877/8b88c55c2a98d5d/reftest-analyzer.html#web=eq.log |
The `sizes` property doesn't appear to have been used ever since the code was first split into main/worker-threads, which is so many years ago that I wasn't able to easily find exactly in which PR/commit it became unused. The `encoding` property is always assigned the `properties.baseEncoding` value, however the `PartialEvaluator` doesn't actually compute/set that value any more. Again it was difficult to determine when it became unused, but it's been that way for years.
681c2f9
to
14c999e
Compare
I've started looking at Lines 1264 to 1265 in fa4b431
|
Thank you for cleaning this up! |
The
sizes
property doesn't appear to have been used ever since the code was first split into main/worker-threads, which is so many years ago that I wasn't able to easily find exactly in which PR/commit it became unused.The
encoding
property is always assigned theproperties.baseEncoding
value, however thePartialEvaluator
doesn't actually compute/set that value any more. Again it was difficult to determine when it became unused, but it's been that way for years.