Remove old API methods which were previously converted to throwing (PR 11219 follow-up) #11734
Conversation
…R 11219 follow-up) These methods were deprecated already in PDF.js version `2.1.266`, see PRs 10246 and 10369, and were converted to throw `Error`s upon invocation in PDF.js version `2.4.456`, see PR 11219. Hence it ought to be possible to remove these methods now.
…docs Please note that the `setPDFNetworkStreamFactory` functionality isn't exposed in the public API, i.e. not listed among the exports in the `src/pdf.js` file, and that even if it were it wouldn't really be useful considering that none of the `PDFNetworkStream`/`PDFFetchStream`/`PDFNodeStream` classes are exported either.
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/9073376f4a7f288/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/a7cb276f1a595da/output.txt |
From: Bot.io (Windows)FailedFull output at http://54.215.176.217:8877/a7cb276f1a595da/output.txt Total script time: 1.80 mins
Image differences available at: http://54.215.176.217:8877/a7cb276f1a595da/reftest-analyzer.html#web=eq.log |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/9073376f4a7f288/output.txt Total script time: 19.67 mins
Image differences available at: http://54.67.70.0:8877/9073376f4a7f288/reftest-analyzer.html#web=eq.log |
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/d3cae278125329d/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/d3cae278125329d/output.txt Total script time: 2.40 mins Published |
|
Agreed. Thanks! |
Remove old API methods which were previously converted to throwing (PR 11219 follow-up)
These methods were deprecated already in PDF.js version
2.1.266, see PRs Convert the remaining code insrc/display/api.jsto use ES6 classes #10246 and [api-minor] Change thegetViewportmethod, onPDFPageProxy, to take a parameter object rather than a bunch of (randomly) ordered parameters #10369, and were converted to throwErrors upon invocation in PDF.js version2.4.456, see PR [api-minor] Replace alldeprecatedcalls with throwing of actualErrors #11219.Hence it ought to be possible to remove these methods now.
Exclude the
setPDFNetworkStreamFactoryfunction from the built API docsPlease note that the
setPDFNetworkStreamFactoryfunctionality isn't exposed in the public API, i.e. not listed among the exports in thesrc/pdf.jsfile, and that even if it were it wouldn't really be useful considering that none of thePDFNetworkStream/PDFFetchStream/PDFNodeStreamclasses are exported either.