Don't let Travis run npm update
during setup
#11721
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Letting Travis update npm packages can lead to unexpected and completely unrelated failures for any PR and/or merge, see e.g. #11719, if there's ever backwards incompatible changes when a package is updated.
The exact package versions are specified in
package-lock.json
, and they should thus be used when running tests. Note that the bots won't update npm packages, and neither should Travis as far as I'm concerned.