Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't let Travis run npm update during setup #11721

Merged
merged 1 commit into from
Mar 20, 2020

Conversation

Snuffleupagus
Copy link
Collaborator

Letting Travis update npm packages can lead to unexpected and completely unrelated failures for any PR and/or merge, see e.g. #11719, if there's ever backwards incompatible changes when a package is updated.

The exact package versions are specified in package-lock.json, and they should thus be used when running tests. Note that the bots won't update npm packages, and neither should Travis as far as I'm concerned.

Letting Travis update npm packages can lead to unexpected and completely unrelated failures for any PR and/or merge, see e.g. 11719, if there's ever backwards *incompatible* changes when a package is updated.

The *exact* package versions are specified in `package-lock.json`, and they should thus be used when running tests. Note that the bots won't update npm packages, and neither should Travis as far as I'm concerned.
@Snuffleupagus
Copy link
Collaborator Author

/botio unittest

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_unittest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.215.176.217:8877/aeb4518bf7b097f/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_unittest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.67.70.0:8877/29cd1f7027bce0f/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/29cd1f7027bce0f/output.txt

Total script time: 2.70 mins

  • Unit Tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://54.215.176.217:8877/aeb4518bf7b097f/output.txt

Total script time: 4.25 mins

  • Unit Tests: Passed

@timvandermeij timvandermeij merged commit 3cebb43 into mozilla:master Mar 20, 2020
@timvandermeij
Copy link
Contributor

It looks like I added that four years ago and I must say I can't recall why, but it shouldn't be necessary to have. Thanks!

@Snuffleupagus Snuffleupagus deleted the travis-no-npm-update branch March 20, 2020 21:37
@Snuffleupagus
Copy link
Collaborator Author

It looks like I added that four years ago and I must say I can't recall why, but it shouldn't be necessary to have. Thanks!

The only thing I can possibly think of is that we didn't use a package-lock.json file until much later, meaning that the installed package versions were more arbitrary. Perhaps the idea was that it's better to be guaranteed to use the latest versions, rather than a more arbitrary state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants