Search highlighting not cleared after search is done #7468
Labels
Comments
timvandermeij
added a commit
to timvandermeij/pdf.js
that referenced
this issue
Sep 21, 2018
…ency on the find controller from the find bar If the find bar is closed, the matches for the rendered pages remain highlighted (issue mozilla#7468 tracks this). The only purpose of the `active` member variable is to not highlight matches for not yet rendered pages, so if the find bar is closed and a not yet rendered page is scrolled into view, then the text layer is built without match highlights. However, this is not the behavior of the built-in version in Firefox, which uses the native find bar of Firefox. Therefore, this behavior is inconsistent. Moreover, this is the only reason we have a dependency on the find controller from the find bar. Therefore, we remove this functionality altogether since, if we want this, it should be implemented properly as tracked in issue mozilla#7468 and not partially and inconsistently as in the current state.
This was referenced Sep 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Link to PDF file (or attach file here): https://www.cca.edu/sites/default/files/pdf/08/word-to-pdf.pdf
Configuration:
Steps to reproduce the problem:
What is the expected behavior? (add screenshot)
Text highlighting should be removed
What went wrong? (add screenshot)
Text highlighting stays
Link to a viewer (if hosted on a site other than mozilla.github.io/pdf.js or as Firefox/Chrome extension):
The text was updated successfully, but these errors were encountered: