-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Close issues only relevant for IE 11/Edge #11211
Comments
I agree with this. We don't have the resources to address IE/Edge-only issues and we haven't seen many contributions for this either. Given that |
There's now been a month since this issue was opened, and (obviously) nothing has come to light which would prevent going forward with this plan as far as I can tell. Furthermore no one has objected either, although that would've needed to be accompanied by very good arguments. @timvandermeij Unless you disagree with the time-line; would you mind going through and closing all the relevant issues as outlined by the links in #11211 (comment)? |
I think I've had them all, but there were lots of search results, so I might have still missed some. If there are more, please add a comment here and we can close them. |
@timvandermeij Thanks a lot for doing this; it's nice to not have lots of non-actionable issues open! |
Just to clarify: are the issues that are being closed for IE/Edge limited to the Trident/EdgeHTML browser engines? Will the project still accept issues for the Chromium-based versions of Edge (currently in beta, for general release on January 15, 2020)? |
Yes, this only applies to non-Chromium-based IE/Edge versions. |
As outlined in the FAQ, see https://github.com/mozilla/pdf.js/wiki/Frequently-Asked-Questions#faq-support, support for IE 11/Edge is limited and will eventually be completely removed:
The idea here is obviously to eventually (or hopefully soon) remove support for these old browsers, such that most (if not all) compatibility code can be removed and the build scripts be simplified.
However, even with the current limited support status for IE 11/Edge, it's seems highly questionable (to me) if it makes sense to keep issues which are only relevant to IE 11/Edge open.
Basically, the open issues can be qualified into a couple of main categories:
src/shared/compatibility.js
and thus won't be accepted.This leads to the conclusion that most IE 11/Edge issues either can't or won't be fixed, and that the rest would at this point in time essentially be a waste of developer/reviewer resources to even attempt to address (where technically possible).
It thus seems, at least to me, that it would be much better to close all of the relevant issues as WONTFIX, pointing to https://github.com/mozilla/pdf.js/wiki/Frequently-Asked-Questions#faq-support, such that we can clean-up the tracker a little bit.[1]
This would include all issues labelled with:
... and then possibly ones satisfying the follow searches (since some issues could be incorrectly labelled):
[1] It would also be clearer since having a (somewhat) large number of issue open, when they will never be fixed, could easily give users the false hope that they will someday be addressed.
The text was updated successfully, but these errors were encountered: