Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move chokidar to peerDependencies and make it optional via peerDependenciesMeta #1329

Merged
merged 3 commits into from
Nov 25, 2020

Conversation

rdmurphy
Copy link
Contributor

@rdmurphy rdmurphy commented Nov 16, 2020

Summary

Proposed change:

This pull request implements the discussed solution to #1227 and moves chokidar from optionalDependencies (which never did what it aspired to do) to peerDependencies, and uses the recently implemented peerDependenciesMeta field to mark it as optional. This means for npm users using a version that supports peerDependenciesMeta, chokidar will have to be separately installed. This is in particularly relevant to the newest version of npm (v7), which installs peerDependencies by default unless the package is marked as optional.

Closes #1227.

Checklist

I've completed the checklist below to ensure I didn't forget anything. This makes reviewing this PR as easy as possible for the maintainers. And it gets this change released as soon as possible.

@fdintino fdintino merged commit f51afa3 into mozilla:master Nov 25, 2020
@fdintino
Copy link
Collaborator

Thank you for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revisit the watch option and chokidar dependency
2 participants