Move chokidar to peerDependencies and make it optional via peerDependenciesMeta #1329
+22
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Proposed change:
This pull request implements the discussed solution to #1227 and moves
chokidar
fromoptionalDependencies
(which never did what it aspired to do) topeerDependencies
, and uses the recently implementedpeerDependenciesMeta
field to mark it asoptional
. This means fornpm
users using a version that supportspeerDependenciesMeta
,chokidar
will have to be separately installed. This is in particularly relevant to the newest version ofnpm
(v7), which installspeerDependencies
by default unless the package is marked asoptional
.Closes #1227.
Checklist
I've completed the checklist below to ensure I didn't forget anything. This makes reviewing this PR as easy as possible for the maintainers. And it gets this change released as soon as possible.