Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log in to docker hub before pulling images #2277

Merged
merged 2 commits into from
Oct 23, 2020
Merged

Log in to docker hub before pulling images #2277

merged 2 commits into from
Oct 23, 2020

Conversation

mythmon
Copy link
Contributor

@mythmon mythmon commented Oct 22, 2020

Fixes #2272

@mythmon mythmon requested a review from sciurus October 22, 2020 21:38
sciurus
sciurus suggested changes Oct 23, 2020
View reviewed changes
Copy link
Contributor

@sciurus sciurus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think also need to log in within the "docker-image-build" job before the "Build Docker image" step like at https://github.com/mozilla-services/Dockerflow/blob/master/.circleci/config.yml#L31-L38

@mythmon
Copy link
Contributor Author

mythmon commented Oct 23, 2020

bors r= @sciurus

@bors
Copy link
Contributor

bors bot commented Oct 23, 2020

Build succeeded:

@bors bors bot merged commit 7a6113a into master Oct 23, 2020
@bors bors bot deleted the login-to-dockerhub branch October 23, 2020 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sciurus sciurus sciurus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Log in to docker hub before pulling images
2 participants
@mythmon @sciurus