Bump version of cfg_aliases to deal with nightly clippy errors - #3833
Bump version of cfg_aliases to deal with nightly clippy errors#3833martinthomson wants to merge 3 commits into
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Straightforward dependency bump. One suggestion: bump the workspace-level cfg_aliases version (in the root Cargo.toml) to "0.2.2" as well, and have mtu use { workspace = true } like neqo-udp and neqo-bin already do. This keeps the minimum version constraint consistent across all crates in the workspace.
Also worth checking: the #[allow(clippy::allow_attributes, semicolon_in_expressions_from_macros)] blocks in mtu/build.rs, neqo-udp/build.rs, and neqo-bin/build.rs all carry a TODO referencing cfg_aliases PR #15. If that fix shipped in 0.2.2, those #[allow] blocks can be removed as a follow-up.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3833 +/- ##
==========================================
- Coverage 96.95% 96.78% -0.18%
==========================================
Files 115 120 +5
Lines 40537 40882 +345
Branches 40537 40882 +345
==========================================
+ Hits 39304 39567 +263
- Misses 1216 1290 +74
- Partials 17 25 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Merging this PR will degrade performance by 8.72%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Memory | simulated/10-streams/each-1048576-bytes |
9.7 MB | 11.4 MB | -15.16% |
| ❌ | Simulation | simulated/10-streams/each-1048576-bytes |
230.1 ms | 246.3 ms | -6.59% |
| ❌ | Simulation | coalesce_acked_from_zero 1 ranges |
1.4 µs | 1.4 µs | -4.03% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing martinthomson:bump-cfg_aliases (bbacd2b) with main (76673b1)
There was a problem hiding this comment.
Straightforward and correct dependency bump. The second commit nicely consolidates mtu/Cargo.toml to use the workspace dependency, keeping all three crates (mtu, neqo-udp, neqo-bin) consistent.
The previous review's inline suggestion has been addressed. One optional follow-up noted inline: the #[allow] blocks in the three build.rs files can now be removed since the fix they were waiting on (katharostech/cfg_aliases#15) shipped in 0.2.2.
|
|
||
| [workspace.dependencies] | ||
| cfg_aliases = { version = "0.2", default-features = false } | ||
| cfg_aliases = { version = "0.2.2", default-features = false } |
There was a problem hiding this comment.
Tip
Now that cfg_aliases 0.2.2 includes the fix from katharostech/cfg_aliases#15, the #[allow(clippy::allow_attributes, semicolon_in_expressions_from_macros)] blocks in mtu/build.rs, neqo-udp/build.rs, and neqo-bin/build.rs can be removed — their TODOs reference exactly this release. Could be done here or as a quick follow-up.
There was a problem hiding this comment.
Clean dependency bump. The three commits tell a good story: bump cfg_aliases 0.2.1 → 0.2.2 to fix nightly clippy warnings, consolidate mtu/Cargo.toml to use the workspace dependency (matching neqo-udp and neqo-bin), and remove the #[allow(clippy::allow_attributes, semicolon_in_expressions_from_macros)] workarounds now that the upstream fix (katharostech/cfg_aliases#15) has shipped.
The CodSpeed regressions are flagged as cross-environment comparisons and unrelated to this build-time-only change.
Benchmark resultsNo significant performance differences relative to 76673b1. All resultsstreams/walltime/1-streams/each-1000-bytes time: [548.96 µs 550.99 µs 553.33 µs]
thrpt: [1.7235 MiB/s 1.7308 MiB/s 1.7372 MiB/s]
Found 15 outliers among 100 measurements (15.00%)
2 (2.00%) low mild
1 (1.00%) high mild
12 (12.00%) high severestreams/walltime/1000-streams/each-1-bytes time: [11.096 ms 11.110 ms 11.125 ms]
thrpt: [87.780 KiB/s 87.897 KiB/s 88.014 KiB/s]streams/walltime/1000-streams/each-1000-bytes time: [31.686 ms 31.736 ms 31.790 ms]
thrpt: [29.999 MiB/s 30.050 MiB/s 30.098 MiB/s]
Found 2 outliers among 100 measurements (2.00%)
2 (2.00%) high mildstreams-flow-controlled/walltime/1-streams/each-4194304-bytes time: [26.430 ms 26.468 ms 26.507 ms]
thrpt: [150.90 MiB/s 151.12 MiB/s 151.34 MiB/s]streams-flow-controlled/walltime/10-streams/each-1048576-bytes time: [69.537 ms 69.968 ms 70.402 ms]
thrpt: [142.04 MiB/s 142.92 MiB/s 143.81 MiB/s]transfer/walltime/pacing-false/varying-seeds time: [18.846 ms 18.858 ms 18.870 ms]
thrpt: [211.97 MiB/s 212.11 MiB/s 212.25 MiB/s]transfer/walltime/pacing-true/varying-seeds time: [19.119 ms 19.130 ms 19.140 ms]
thrpt: [208.98 MiB/s 209.10 MiB/s 209.22 MiB/s]
Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high mildtransfer/walltime/pacing-false/same-seed time: [18.628 ms 18.640 ms 18.652 ms]
thrpt: [214.45 MiB/s 214.59 MiB/s 214.73 MiB/s]
Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high mildtransfer/walltime/pacing-true/same-seed time: [18.935 ms 18.948 ms 18.961 ms]
thrpt: [210.96 MiB/s 211.11 MiB/s 211.25 MiB/s]
Found 2 outliers among 100 measurements (2.00%)
2 (2.00%) high mildDownload data for |
Failed Interop TestsQUIC Interop Runner, client vs. server, differences relative to
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-pr as client
neqo-pr as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-pr as client
neqo-pr as server
|
Client/server transfer resultsPerformance differences relative to 76673b1. Transfer of 33554432 bytes over loopback, min. 100 runs. All unit-less numbers are in milliseconds.
Table above only shows statistically significant changes. See all results below. All resultsTransfer of 33554432 bytes over loopback, min. 100 runs. All unit-less numbers are in milliseconds.
Download data for |
1 participant
No description provided.