chore: Suppress new clippy lints#3815
Merged
Merged
Conversation
katharostech/cfg_aliases#15 has the fixm but needs to release and we need to bump the dep.
larseggert
requested review from
KershawChang,
martinthomson and
mxinden
as code owners
July 16, 2026 11:55
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Straightforward workaround for new clippy lints triggered by the cfg_aliases! macro. All three affected build.rs files are covered, and the reason + upstream PR link makes the TODO easy to track.
One suggestion across all three sites: switching from #[allow] to #[expect] would drop the clippy::allow_attributes suppression (since #[expect] doesn't trigger it) and give a compiler warning when the upstream fix lands — turning the TODO into a self-enforcing reminder.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds temporary lint suppression around cfg_aliases usage in several build.rs scripts to keep the workspace clean while waiting for an upstream cfg_aliases fix/release.
Changes:
- Suppresses
semicolon_in_expressions_from_macroswarnings triggered bycfg_aliasesmacro expansion in build scripts. - Adds a workspace-clippy suppression for
clippy::allow_attributesto permit the lint suppression attribute itself. - Adds a TODO reason string pointing to the upstream PR that will remove the need for this suppression.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| neqo-udp/build.rs | Adds lint suppression attribute around main() to unblock cfg_aliases! usage. |
| neqo-bin/build.rs | Same lint suppression pattern for the binary crate build script. |
| mtu/build.rs | Same lint suppression pattern for the MTU crate build script. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3815 +/- ##
==========================================
- Coverage 96.95% 96.78% -0.18%
==========================================
Files 115 120 +5
Lines 40509 40854 +345
Branches 40509 40854 +345
==========================================
+ Hits 39276 39540 +264
- Misses 1216 1289 +73
- Partials 17 25 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Merging this PR will improve performance by 9.28%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | Memory | simulated/10-streams/each-1048576-bytes |
11.4 MB | 10.5 MB | +9.28% |
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing larseggert:chore-clippy (ced8d47) with main (8a04d06)
Contributor
Benchmark resultsNo significant performance differences relative to 8a04d06. All resultsstreams/walltime/1-streams/each-1000-bytes: No change in performance detected. time: [547.93 µs 549.73 µs 551.83 µs]
thrpt: [1.7282 MiB/s 1.7348 MiB/s 1.7405 MiB/s]
change:
time: [-0.5417% -0.0373% +0.4405] (p = 0.89 > 0.05)
thrpt: [-0.4385% +0.0373% +0.5447]
No change in performance detected.
Found 13 outliers among 100 measurements (13.00%)
1 (1.00%) low mild
3 (3.00%) high mild
9 (9.00%) high severestreams/walltime/1000-streams/each-1-bytes: Change within noise threshold. time: [11.038 ms 11.054 ms 11.071 ms]
thrpt: [88.209 KiB/s 88.343 KiB/s 88.473 KiB/s]
change:
time: [+0.0570% +0.2693% +0.4884] (p = 0.01 < 0.05)
thrpt: [-0.4860% -0.2686% -0.0570]
Change within noise threshold.streams/walltime/1000-streams/each-1000-bytes: Change within noise threshold. time: [32.370 ms 32.409 ms 32.448 ms]
thrpt: [29.391 MiB/s 29.426 MiB/s 29.461 MiB/s]
change:
time: [+0.1168% +0.2908% +0.4741] (p = 0.00 < 0.05)
thrpt: [-0.4719% -0.2900% -0.1167]
Change within noise threshold.
Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high mildstreams-flow-controlled/walltime/1-streams/each-4194304-bytes: Change within noise threshold. time: [26.945 ms 26.986 ms 27.027 ms]
thrpt: [148.00 MiB/s 148.23 MiB/s 148.45 MiB/s]
change:
time: [+1.0486% +1.2712% +1.4956] (p = 0.00 < 0.05)
thrpt: [-1.4736% -1.2553% -1.0378]
Change within noise threshold.streams-flow-controlled/walltime/10-streams/each-1048576-bytes: Change within noise threshold. time: [70.937 ms 71.379 ms 71.812 ms]
thrpt: [139.25 MiB/s 140.10 MiB/s 140.97 MiB/s]
change:
time: [+0.3019% +1.1927% +2.0397] (p = 0.01 < 0.05)
thrpt: [-1.9989% -1.1786% -0.3010]
Change within noise threshold.transfer/walltime/pacing-false/varying-seeds: Change within noise threshold. time: [18.573 ms 18.584 ms 18.595 ms]
thrpt: [215.11 MiB/s 215.24 MiB/s 215.37 MiB/s]
change:
time: [-1.3368% -1.2592% -1.1738] (p = 0.00 < 0.05)
thrpt: [+1.1878% +1.2753% +1.3549]
Change within noise threshold.
Found 6 outliers among 100 measurements (6.00%)
6 (6.00%) high mildtransfer/walltime/pacing-true/varying-seeds: No change in performance detected. time: [18.931 ms 18.943 ms 18.955 ms]
thrpt: [211.03 MiB/s 211.16 MiB/s 211.29 MiB/s]
change:
time: [-0.1794% -0.0805% +0.0193] (p = 0.10 > 0.05)
thrpt: [-0.0193% +0.0806% +0.1798]
No change in performance detected.
Found 4 outliers among 100 measurements (4.00%)
2 (2.00%) low mild
2 (2.00%) high mildtransfer/walltime/pacing-false/same-seed: Change within noise threshold. time: [18.819 ms 18.829 ms 18.839 ms]
thrpt: [212.32 MiB/s 212.44 MiB/s 212.55 MiB/s]
change:
time: [+0.9212% +1.0026% +1.0862] (p = 0.00 < 0.05)
thrpt: [-1.0745% -0.9927% -0.9128]
Change within noise threshold.
Found 6 outliers among 100 measurements (6.00%)
3 (3.00%) low mild
3 (3.00%) high mildtransfer/walltime/pacing-true/same-seed: Change within noise threshold. time: [18.698 ms 18.709 ms 18.721 ms]
thrpt: [213.67 MiB/s 213.80 MiB/s 213.93 MiB/s]
change:
time: [-2.3757% -2.2951% -2.2133] (p = 0.00 < 0.05)
thrpt: [+2.2634% +2.3490% +2.4335]
Change within noise threshold.
Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high mildDownload data for |
Contributor
Failed Interop TestsQUIC Interop Runner, client vs. server, differences relative to
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-pr as client
neqo-pr as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-pr as client
neqo-pr as server
|
Contributor
Client/server transfer resultsPerformance differences relative to 8a04d06. No significant performance differences. Table above only shows statistically significant changes. See all results below. All resultsTransfer of 33554432 bytes over loopback, min. 100 runs. All unit-less numbers are in milliseconds.
Download data for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
katharostech/cfg_aliases#15 has the fix, but needs to release and we need to bump the dep.