Toggle pedantic on neqo common #374
Conversation
o0Ignition0o
force-pushed
the
pedantic_neqo_common
branch
from
c70d6f3 to
0bee0bd
Compare
neqo-crypto/src/aead.rs
Outdated
| // The directive is placed here because | ||
| // we cannot stack directives. | ||
| // Placing it on top of #[must_use] doesn't work. | ||
| #[allow(clippy::unused_self)] |
There was a problem hiding this comment.
It seems like this lint did not exist for the toolchain our CI uses.
Not really sure if/when we want to bump versions, so I'll remove this directive for now.
Let's keep in mind we will have to add it again once we update our clippy/rustc versions in the CI
o0Ignition0o
force-pushed
the
pedantic_neqo_common
branch
from
0bee0bd to
6f4a280
Compare
neqo-transport/src/frame.rs
Outdated
| let (fin, fill) = if data.len() > remaining { | ||
| if remaining == 0 { | ||
| return None; | ||
| let (fin, fill) = match data.len().cmp(&remaining) { |
neqo-transport/src/recv_stream.rs
Outdated
| @@ -523,7 +523,7 @@ mod tests { | |||
| let flow_mgr = Rc::new(RefCell::new(FlowMgr::default())); | |||
| let conn_events = ConnectionEvents::default(); | |||
|
|
|||
| let mut s = RecvStream::new(567.into(), 1024, flow_mgr.clone(), conn_events.clone()); | |||
| let mut s = RecvStream::new(567.into(), 1024, flow_mgr, conn_events); | |||
There was a problem hiding this comment.
I'm not sure that I follow this change. These are Rc<> instances that presumably we want to clone for passing into multiple invocations of this function. Has Rc picked up an implementation of Copy in a recent version of rust?
I would have thought that moving to Rc::clone(&flow_mgr) would be wise, but I don't see that here either.
There was a problem hiding this comment.
Oh nice catch, I'll move it to Rc::clone() to make it more explicit.
I think I got fooled by the linter, which advises to remove .clone(), which doesn't make sense in an Rc context.
It might be worth opening an issue to clippy.
Edit: just did rust-lang/rust-clippy#4982
o0Ignition0o
force-pushed
the
pedantic_neqo_common
branch
from
6f4a280 to
4e17ba1
Compare
o0Ignition0o
force-pushed
the
pedantic_neqo_common
branch
from
4e17ba1 to
cc36db5
Compare
|
Rebased against master, now that #370 has merged |
o0Ignition0o
force-pushed
the
pedantic_neqo_common
branch
from
cc36db5 to
2d335d2
Compare
o0Ignition0o
force-pushed
the
pedantic_neqo_common
branch
from
2d335d2 to
ca0a53e
Compare
Please let me know if you would like me to squash the commits, and if there's anything I can do to improve the PR :)