chore: Use EnumSet instead of a Boolean EnumMap
#2443
+16
−110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For `PacketNumberSpaceSet`. May be faster?
larseggert
requested review from
KershawChang,
martinthomson and
mxinden
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2443 +/- ##
==========================================
- Coverage 95.26% 95.25% -0.01%
==========================================
Files 115 115
Lines 37198 37132 -66
Branches 37198 37132 -66
==========================================
- Hits 35436 35370 -66
Misses 1756 1756
Partials 6 6 ☔ View full report in Codecov by Sentry. |
Failed Interop TestsQUIC Interop Runner, client vs. server, differences relative to d247751. neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
mxinden
reviewed
Feb 13, 2025
Benchmark resultsPerformance differences relative to ef6e6f4. decode 4096 bytes, mask ff: 💔 Performance has regressed. time: [12.334 µs 12.378 µs 12.427 µs]
change: [+12.542% +13.448% +14.269%] (p = 0.00 < 0.05)
decode 1048576 bytes, mask ff: 💚 Performance has improved. time: [2.8370 ms 2.8471 ms 2.8585 ms]
change: [-9.7144% -9.2686% -8.8241%] (p = 0.00 < 0.05)
decode 4096 bytes, mask 7f: 💔 Performance has regressed. time: [20.847 µs 20.898 µs 20.954 µs]
change: [+17.793% +18.277% +18.812%] (p = 0.00 < 0.05)
decode 1048576 bytes, mask 7f: 💚 Performance has improved. time: [4.5406 ms 4.5517 ms 4.5645 ms]
change: [-16.129% -15.851% -15.566%] (p = 0.00 < 0.05)
decode 4096 bytes, mask 3f: 💔 Performance has regressed. time: [8.2538 µs 8.2754 µs 8.3041 µs]
change: [+25.923% +26.695% +27.437%] (p = 0.00 < 0.05)
decode 1048576 bytes, mask 3f: 💚 Performance has improved. time: [1.5883 ms 1.5939 ms 1.6008 ms]
change: [-9.6672% -9.3528% -8.8799%] (p = 0.00 < 0.05)
coalesce_acked_from_zero 1+1 entries: No change in performance detected. time: [91.412 ns 91.754 ns 92.093 ns]
change: [-0.3013% +0.1212% +0.5387%] (p = 0.59 > 0.05)
coalesce_acked_from_zero 3+1 entries: Change within noise threshold. time: [109.97 ns 110.70 ns 111.80 ns]
change: [+0.1890% +0.7319% +1.4248%] (p = 0.01 < 0.05)
coalesce_acked_from_zero 10+1 entries: No change in performance detected. time: [109.56 ns 110.09 ns 110.70 ns]
change: [-0.5935% +0.1181% +0.9079%] (p = 0.76 > 0.05)
coalesce_acked_from_zero 1000+1 entries: No change in performance detected. time: [93.739 ns 93.910 ns 94.098 ns]
change: [-0.6786% +0.4624% +1.6186%] (p = 0.47 > 0.05)
RxStreamOrderer::inbound_frame(): Change within noise threshold. time: [111.78 ms 111.84 ms 111.89 ms]
change: [+0.1843% +0.2532% +0.3242%] (p = 0.00 < 0.05)
SentPackets::take_ranges: No change in performance detected. time: [5.1573 µs 5.2454 µs 5.3345 µs]
change: [-4.8669% -2.2939% +0.3611%] (p = 0.10 > 0.05)
transfer/pacing-false/varying-seeds: No change in performance detected. time: [34.272 ms 34.340 ms 34.408 ms]
change: [-0.1032% +0.2137% +0.5171%] (p = 0.18 > 0.05)
transfer/pacing-true/varying-seeds: Change within noise threshold. time: [34.794 ms 34.861 ms 34.930 ms]
change: [+1.1178% +1.4297% +1.7235%] (p = 0.00 < 0.05)
transfer/pacing-false/same-seed: Change within noise threshold. time: [34.741 ms 34.826 ms 34.916 ms]
change: [+0.7578% +1.0582% +1.3571%] (p = 0.00 < 0.05)
transfer/pacing-true/same-seed: Change within noise threshold. time: [35.373 ms 35.438 ms 35.510 ms]
change: [+1.7696% +2.0292% +2.3059%] (p = 0.00 < 0.05)
1-conn/1-100mb-resp/mtu-1504 (aka. Download)/client: No change in performance detected. time: [838.17 ms 846.38 ms 854.77 ms]
thrpt: [116.99 MiB/s 118.15 MiB/s 119.31 MiB/s]
change:
time: [-2.6167% -1.1321% +0.4323%] (p = 0.16 > 0.05)
thrpt: [-0.4304% +1.1451% +2.6870%]
1-conn/10_000-parallel-1b-resp/mtu-1504 (aka. RPS)/client: No change in performance detected. time: [313.67 ms 317.12 ms 320.63 ms]
thrpt: [31.189 Kelem/s 31.534 Kelem/s 31.880 Kelem/s]
change:
time: [-2.1544% -0.6690% +0.8923%] (p = 0.38 > 0.05)
thrpt: [-0.8844% +0.6735% +2.2018%]
1-conn/1-1b-resp/mtu-1504 (aka. HPS)/client: No change in performance detected. time: [25.361 ms 25.525 ms 25.691 ms]
thrpt: [38.924 elem/s 39.178 elem/s 39.430 elem/s]
change:
time: [-1.5462% -0.6063% +0.3938%] (p = 0.22 > 0.05)
thrpt: [-0.3923% +0.6100% +1.5705%]
1-conn/1-100mb-resp/mtu-1504 (aka. Upload)/client: 💚 Performance has improved. time: [1.8072 s 1.8230 s 1.8388 s]
thrpt: [54.382 MiB/s 54.854 MiB/s 55.334 MiB/s]
change:
time: [-4.8230% -3.6139% -2.3112%] (p = 0.00 < 0.05)
thrpt: [+2.3659% +3.7494% +5.0674%]
Client/server transfer resultsPerformance differences relative to ef6e6f4. Transfer of 33554432 bytes over loopback, 30 runs. All unit-less numbers are in milliseconds.
|
martinthomson
approved these changes
Feb 13, 2025
mxinden
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For
PacketNumberSpaceSet. May be faster?