fix: Reset bench table highlights after each test #2441
Merged
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise the highlight for a significant change will stay in effect for following non-significant changes.
larseggert
requested review from
KershawChang,
martinthomson and
mxinden
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2441 +/- ##
=======================================
Coverage 95.26% 95.26%
=======================================
Files 115 115
Lines 37198 37198
Branches 37198 37198
=======================================
Hits 35436 35436
Misses 1756 1756
Partials 6 6 ☔ View full report in Codecov by Sentry. |
Failed Interop TestsQUIC Interop Runner, client vs. server, differences relative to 966ece6. neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
Benchmark resultsPerformance differences relative to 966ece6. decode 4096 bytes, mask ff: No change in performance detected. time: [12.316 µs 12.351 µs 12.392 µs]
change: [-0.6072% +0.0180% +0.6540%] (p = 0.96 > 0.05)
decode 1048576 bytes, mask ff: No change in performance detected. time: [2.8441 ms 2.8568 ms 2.8711 ms]
change: [-0.2587% +0.3903% +0.9930%] (p = 0.23 > 0.05)
decode 4096 bytes, mask 7f: No change in performance detected. time: [20.866 µs 20.930 µs 21.002 µs]
change: [-0.4908% -0.0476% +0.3735%] (p = 0.83 > 0.05)
decode 1048576 bytes, mask 7f: No change in performance detected. time: [4.5441 ms 4.5653 ms 4.5956 ms]
change: [-0.2065% +0.3083% +1.1088%] (p = 0.38 > 0.05)
decode 4096 bytes, mask 3f: No change in performance detected. time: [8.2840 µs 8.3238 µs 8.3697 µs]
change: [-0.2636% +0.2651% +0.8007%] (p = 0.35 > 0.05)
decode 1048576 bytes, mask 3f: No change in performance detected. time: [1.5887 ms 1.5943 ms 1.6012 ms]
change: [-0.4949% +0.0391% +0.6512%] (p = 0.87 > 0.05)
coalesce_acked_from_zero 1+1 entries: No change in performance detected. time: [91.296 ns 91.606 ns 91.917 ns]
change: [-0.3141% +0.2270% +0.8552%] (p = 0.48 > 0.05)
coalesce_acked_from_zero 3+1 entries: No change in performance detected. time: [109.69 ns 110.04 ns 110.42 ns]
change: [-0.4621% -0.0411% +0.3699%] (p = 0.85 > 0.05)
coalesce_acked_from_zero 10+1 entries: No change in performance detected. time: [109.23 ns 109.64 ns 110.15 ns]
change: [-1.1111% -0.3765% +0.1585%] (p = 0.29 > 0.05)
coalesce_acked_from_zero 1000+1 entries: No change in performance detected. time: [93.655 ns 98.959 ns 110.57 ns]
change: [-0.0564% +2.9438% +7.5600%] (p = 0.17 > 0.05)
RxStreamOrderer::inbound_frame(): Change within noise threshold. time: [112.32 ms 112.46 ms 112.64 ms]
change: [+0.0478% +0.1801% +0.3409%] (p = 0.01 < 0.05)
SentPackets::take_ranges: No change in performance detected. time: [5.1960 µs 5.2939 µs 5.3954 µs]
change: [-5.4210% -2.1285% +0.9549%] (p = 0.20 > 0.05)
transfer/pacing-false/varying-seeds: Change within noise threshold. time: [34.033 ms 34.093 ms 34.161 ms]
change: [-0.9165% -0.6745% -0.4106%] (p = 0.00 < 0.05)
transfer/pacing-true/varying-seeds: Change within noise threshold. time: [34.135 ms 34.189 ms 34.242 ms]
change: [-1.1394% -0.9345% -0.7333%] (p = 0.00 < 0.05)
transfer/pacing-false/same-seed: Change within noise threshold. time: [34.657 ms 34.708 ms 34.762 ms]
change: [+0.5433% +0.7806% +1.0082%] (p = 0.00 < 0.05)
transfer/pacing-true/same-seed: Change within noise threshold. time: [34.972 ms 35.035 ms 35.107 ms]
change: [+1.5534% +1.8256% +2.1070%] (p = 0.00 < 0.05)
1-conn/1-100mb-resp/mtu-1504 (aka. Download)/client: No change in performance detected. time: [832.66 ms 842.24 ms 852.24 ms]
thrpt: [117.34 MiB/s 118.73 MiB/s 120.10 MiB/s]
change:
time: [-0.4399% +1.1780% +2.8842%] (p = 0.16 > 0.05)
thrpt: [-2.8034% -1.1643% +0.4419%]
1-conn/10_000-parallel-1b-resp/mtu-1504 (aka. RPS)/client: No change in performance detected. time: [316.69 ms 320.36 ms 324.00 ms]
thrpt: [30.864 Kelem/s 31.215 Kelem/s 31.576 Kelem/s]
change:
time: [-2.2439% -0.7547% +0.7800%] (p = 0.34 > 0.05)
thrpt: [-0.7740% +0.7605% +2.2954%]
1-conn/1-1b-resp/mtu-1504 (aka. HPS)/client: No change in performance detected. time: [25.487 ms 25.673 ms 25.865 ms]
thrpt: [38.663 elem/s 38.952 elem/s 39.235 elem/s]
change:
time: [-0.7106% +0.3021% +1.1922%] (p = 0.55 > 0.05)
thrpt: [-1.1781% -0.3012% +0.7157%]
1-conn/1-100mb-resp/mtu-1504 (aka. Upload)/client: No change in performance detected. time: [1.8294 s 1.8495 s 1.8702 s]
thrpt: [53.470 MiB/s 54.068 MiB/s 54.664 MiB/s]
change:
time: [-2.2984% -0.7533% +0.8415%] (p = 0.34 > 0.05)
thrpt: [-0.8345% +0.7590% +2.3525%]
Client/server transfer resultsPerformance differences relative to 966ece6. Transfer of 33554432 bytes over loopback, 30 runs. All unit-less numbers are in milliseconds.
|
martinthomson
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise the highlight for a significant change will stay in effect for following non-significant changes.