Remember choice for default containers in the "Always open in" confirm page

[rafeerahman]

Before submitting your pull request

• I agree to license my code under the MPL 2.0 license.
• I rebased my work on top of the main branch.
• I ran npm test and all tests passed.
• I added test coverages if relevant.

Description

When a user is on the confirm-page after re-opening a site they chose to 'always open in a container', if they click "Remember my choice" and then "Open in current tab" (default container), this is not remembered. i.e. The next time they open the site, they are prompted to this screen again.

This PR fixes that.

How to test

(Remember choice for default container)

• Go to youtube.com
• In the browserAction menu, choose "Always Open This Site in..."
• Choose the work container
• Open youtube.com in a new tab.
• On the confirmation page prompt, check "Remember my decision for this site" then click "Open in current tab"
• Open youtube.com in a new tab, and verify that there is no confirmation page. (if you want to put it in a container again, click "Always Open This Site In....")
• In the work containers "site list" verify that it is empty.

(Switching between two containers)

• Go to youtube.com
• In the browserAction menu, choose "Always Open This Site in..."
• Choose the Work container, youtube will open in this container
• In the browserAction menu, choose "Always Open This Site in..."
• Choose the Personal container
• On the confirmation page, check "remember my decision for this site".
• Choose the "Work" container (the option on the left).
• Verify that the choice is remembered.

Type of change

Select all that apply.

• Bug fix
• New feature
• Major change (fix or feature that would cause existing functionality to work differently than in the current version)

Tag issues related to this pull request:

• Add option to "always open in no container" #2603

[rafeerahman]

Also looking into integrating / fixing #2617, which tries to remember the choice when switching to a container that is not the "default container" (i.e. not "Open in current tab").

[groovecoder]

Couple blocking changes.

Can you write out the steps you used to spot-check this? I tried:

1. Go to accounts.firefox.com
2. In the browserAction menu, choose "Always Open This Site in..."
3. In the list of containers, choose "Work"
4. Close the tab
5. Open a new window
6. Go to accounts.firefox.com

Expected Result:

• I should be prompted to confirm I want to open the site in a Work tab

Actual Result:

• I'm not prompted to confirm I want to open the site in a Work tab

[groovecoder]

Also, please change the commit message to start with fix #2603: so that GitHub will automatically link this PR with the corresponding issue.

[rafeerahman]

Couple blocking changes.

Can you write out the steps you used to spot-check this? I tried:

1. Go to accounts.firefox.com

2. In the browserAction menu, choose "Always Open This Site in..."

3. In the list of containers, choose "Work"

4. Close the tab

5. Open a new window

6. Go to accounts.firefox.com

Expected Result:

* I should be prompted to confirm I want to open the site in a Work tab

Actual Result:

* I'm not prompted to confirm I want to open the site in a Work tab

This seems to be a bug in the production version as well. On the firefox accounts website, I get this error both locally and in prod,
.

Heres how I spot checked:

1. Go to youtube.com
2. In the browserAction menu, choose "Always Open This Site in..."
3. Choose the work container
4. Open youtube.com in a new tab.
5. On the confirmation page prompt, check "Remember my decision for this site" then click "Open in current tab"
6. Open youtube.com in a new tab, and verify that there is no confirmation page. (if you want to put it in a container again, click "Always Open This Site In....")
7. In the work containers "site list" verify that it is empty.

Other checks (switching between two containers):

1. Go to youtube.com
2. In the browserAction menu, choose "Always Open This Site in..."
3. Choose the work container, youtube will open in this container
4. In the browserAction menu, choose "Always Open This Site in..."
5. Choose the Personal container
6. Verify that the existing behavior is valid when choosing a container or remembering the choices.

[groovecoder]

Thanks @rafeerahman I was able to reproduce the bug and the fix on youtube.com.

There's still one more bug that I think is worth fixing:

1. Go to youtube.com
2. In the browserAction menu, choose "Always Open This Site in..."
3. Choose the work container
4. Open youtube.com in a new tab.
5. On the confirmation page prompt, check "Remember my decision for this site" then click "Open in current tab"
6. Open youtube.com in a new tab
   • verify that there is no confirmation page.
   • verify youtube.com opens in default/non-container tab
7. Open the work containers "site list"
   • verify that it is empty.
8. Open a new work tab
9. Go to youtube.com

Expected results:
youtube.com automatically opens in default/non-container tab without prompting

Actual results:
youtube.com opens in work container tab

[achernyakevich-sc]

Maybe optimize it by something like:

if (neverAsk) {
  await browser.runtime.sendMessage({
    method: "neverAsk",
    neverAsk: true,
    cookieStoreId: currentCookieStoreId,
    pageUrl: redirectUrl,
    defaultContainer: !currentContainer
  });
}

[rafeerahman]

Thanks!