Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new shortcut navigation in the browser panel #2501

Merged
merged 1 commit into from
Jun 17, 2023

Conversation

dannycolin
Copy link
Collaborator

  • Add Slash shortcut to focus the filter input
  • Use event.code instead of event.keyCode
  • Add modifier key detection

@dannycolin dannycolin linked an issue Feb 8, 2023 that may be closed by this pull request
2 tasks
@dannycolin dannycolin marked this pull request as ready for review February 8, 2023 19:13
@dannycolin dannycolin linked an issue Feb 8, 2023 that may be closed by this pull request
Copy link
Collaborator

@maxxcrawford maxxcrawford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected except for the modifier keys logic.

How can I test this part?

@dannycolin
Copy link
Collaborator Author

Works as expected except for the modifier keys logic.

WFM. Could you pull the newest commit and retry?

How can I test this part?

For the modifier detection:

  1. Open MAC popup
  2. Press [mod] + [0-9] where `[mod] can be altKey, ctrlKey, shiftKey, metaKey or a combinaison of it.

Expected: Nothing. It should prevent a container to be opened. Only pressing [0-9] should still work.

For the search input focus detection:

  1. Open MAC popup
  2. Press [0-9]

Expected: It should prevent a container to be opened and the [0-9] character should be inserted in the search input.

@dannycolin dannycolin linked an issue Jun 14, 2023 that may be closed by this pull request
2 tasks
- Add Slash shortcut to focus search input
- Use event.code instead of event.keyCode
- Cancel [0-9] shortcuts when modified is pressed
- Cancel [0-9] shortcuts when search input is focused
@dannycolin dannycolin merged commit dae7d92 into mozilla:main Jun 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants