Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remove/restore scripts for nested .git folder #2427

Merged
merged 2 commits into from
Jan 10, 2023

Conversation

maxxcrawford
Copy link
Collaborator

@maxxcrawford maxxcrawford commented Oct 20, 2022

Summary

Add scripts to help dev process

  • dev: The /src/_locales/.github folder causes web-ext run to fail when running the npm run dev script. This folder removal isn't tracked or surfaced during local dev work when working from the root directory.
  • build This script runs web-ext build. There was an error when running when running npm run package that would call for this missing command.

Testing

dev script:

  • Checkout PR
  • Run $ npm run dev
  • Expected: The extension should run locally without any console errors

build script:

  • Checkout PR
  • Run $ npm run package
  • Expected: There should be a new local .zip of the add-on in the /web-ext-artifacts folder folder and that file/folder should not be tracked in git.
  • Run $ git status to confirm new .zip file is not tracked

The /src/_locales/.github folder causes `web-ext run` to fail when running the npm dev script. This folder removal isn't tracked or surfaced during local dev work when working from the root directory.
@maxxcrawford maxxcrawford marked this pull request as ready for review October 20, 2022 14:52
@dannycolin dannycolin linked an issue Dec 8, 2022 that may be closed by this pull request
@dannycolin dannycolin merged commit a91c6b0 into main Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup instructions for development lead to error
2 participants