Skip to content

Firefox stopped asking which container to use when opening links from external apps #2689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 tasks done
scovich opened this issue Nov 7, 2024 · 22 comments
Closed
2 tasks done
Labels
bug Something is broken!

Comments

@scovich
Copy link

scovich commented Nov 7, 2024

Before submitting a bug report

  • I updated to the latest version of Multi-Account Container and tested if I can reproduce the issue
  • I searched for existing reports to see if it hasn't already been reported

Step to reproduce

I use containers to juggle my personal and corporate github accounts, and have set my personal account to always open in "OSS github" container. I intentionally did not check the "remember my decision" box, because I want to confirm on a per-link basis which account to use. This has historically worked well:
Screenshot 2024-11-07 at 8 21 27 AM

For corporate github links, I click the "Open in current tab" button, and for other github links, I click the "Open in OSS github container" button.

Actual behavior

This had all been working great for many months now -- including for links opened by external applications. Unfortunately, in the last week or so it stopped working for links clicked from external apps like Thunderbird or Slack. Instead, it goes straight to the OSS github container without asking, which naturally produces a 404 for corporate github links:
Screenshot 2024-11-07 at 8 27 03 AM

At first, I thought I must have accidentally checked the "remember my decision" box. But if I manually open a new tab and paste the exact same link in the address bar, the container confirmation dialog displays as expected.

This may be relate to #706, except the problem only appeared in for me in the last week or so. I wonder if a recent Firefox update may have broken something? I'm currently on 132.0.1 (osx aarch64).

Expected behavior

It shouldn't matter how a link was opened in a new Firefox tab -- the container tab behavior should be the same (ask, or don't ask, based on whether the "remember my decision" box was checked).

Additional informations

Machine: MacOS Sonoma 14.7 (M1 max)

Firefox version 132.0.2 (but problem was observed with 132.0.1 as well)

Extensions (I did not add or remove any extensions within in the last ~year):

  • uBlock Origin - last updated 2024-11-19
  • Keeper password manager & digital vault - last updated 2024-11-19
  • Okta browser plugin - last updated 2024-11-05
  • Firefox multi-account containers - last updated 2024-09-24
  • Auto tab discard - last updated 2022-12-20
  • Video speed controller - last updated 2021-04-06

Provide a copy of Troubleshooting Information page (optional)

No response

@scovich scovich added the bug Something is broken! label Nov 7, 2024
@achernyakevich-sc
Copy link

@scovich I would recommend to try to fix your case the following way:

  • remove GitHub domain from the list of sites associated with OSS github container to "always open in".
  • check that changing container is not triggering anymore.
  • add GitHub to the list of sites associated with OSS github container to "always open in".
  • check that it will trigger appearance of the Open this site in the assigned Container page.

I suspect that you accidentally ticked Remember my decision for this site so it does not ask you anymore.

If it helped, please, then close this issue as resolved. So other users will see that this way it really works. :)

@scovich
Copy link
Author

scovich commented Nov 15, 2024

@achernyakevich-sc -- as noted in my original post, I had already checked for that before filing this issue. And the confirmation still popped up when opening links from within Firefox in new tabs. Just not when opening external links.

However, at some point this week it just started working again on its own. I see FF is now at 132.0.1, so maybe they fixed something on their end. The extension is still on 8.2.0 (September) release.

Closing as (self) resolved for now. So glad it's working again!

@scovich scovich closed this as completed Nov 15, 2024
@scovich
Copy link
Author

scovich commented Nov 19, 2024

Ugh.. it stopped working again. No changes at all -- I was working my way through github notification emails and suddenly it stopped prompting from one email to the next. I'm not sure what flakiness could cause this.

Confirmed that the box is still not checked -- it still prompts when opening a link from browser history, for example.

@scovich scovich reopened this Nov 19, 2024
@achernyakevich-sc
Copy link

I was working my way through github notification emails and suddenly it stopped prompting from one email to the next.

@scovich Do I understand correct that you click link in the email and it opens in your browser? If so then what mail client do you use? Is it Gmail?

@scovich
Copy link
Author

scovich commented Nov 19, 2024

I click the link in Thunderbird client for M1 Mac (gmail account), and it opens a new tab in browser without asking what tab container to use. When things are working, it opens a new tab that immediately asks which container to use.

@scovich
Copy link
Author

scovich commented Nov 20, 2024

Clicking links from a Slack desktop client has the same problem, so I don't think it's specific to Thunderbird. Copying the url from the address bar of the tab that failed to ask, clicking the + button to open a new tab, and pasting the url into the new tab's address bar does ask which tab container to use. So it's not a problem with the url, and it's not a problem with the "remember my decision" checkbox.

@scovich scovich changed the title Firefox stopped confirming which container to use for a given link Firefox stopped confirming which container to use when opening links from external apps Nov 20, 2024
@scovich scovich changed the title Firefox stopped confirming which container to use when opening links from external apps Firefox stopped asking which container to use when opening links from external apps Nov 20, 2024
@achernyakevich-sc
Copy link

@scovich Could you update issue's description (section Additional informations) and provide information about your operation system (name and version), Firefox and MAC versions, other installed Firefox Add-Ons.

BTW: you could try to disable other Firefox Add-Ons and check does it work properly or no.

@scovich
Copy link
Author

scovich commented Nov 20, 2024

Could you update issue's description (section Additional informations) and provide information about your operation system (name and version), Firefox and MAC versions, other installed Firefox Add-Ons.

Done.

BTW: you could try to disable other Firefox Add-Ons and check does it work properly or no.

Disabled them all, no change (including after a restart)

@achernyakevich-sc
Copy link

@scovich Nothing suspicious at the moment... I would ask you to provide information about MAC options and Permissions. Could you open about:addons page, navigate to Extensions in sidebar, select MAC Add-On and provide screenshot of Options and Permissions tabs.

@scovich
Copy link
Author

scovich commented Nov 20, 2024

I haven't touched either of those since the initial install... but here they are:

Preferences:
image

Permissions:
image

@achernyakevich-sc
Copy link

@scovich Could you try to untick checkbox Preferences -> Tab behavior: -> "Replace tab instead of creating a new one` and check will it fix the problem or no.

@scovich
Copy link
Author

scovich commented Dec 2, 2024

Sorry for the delay responding -- I'm not getting notification emails about changes on this issue for some reason, and I finally came back to check why nothing was happening 🤦

I have a vague memory that I originally had to tick that checkbox very soon after first installing the extension, because of some other unpleasant behavior. But I don't remember what the other problem was. I'll try and report back.

@scovich
Copy link
Author

scovich commented Dec 2, 2024

Tried unticking the checkbox, no change at all when opening external links.

And I also remember now why I had originally checked that box:

If that box is not checked, then restarting firefox doubles all existing tabs whose url is assigned to a container. I end up with a completely blank page for the original tab and url, and a new tab opens next to it asking which container to use:
Screenshot 2024-12-02 at 8 52 16 AM
Screenshot 2024-12-02 at 8 52 26 AM

@scovich
Copy link
Author

scovich commented Dec 2, 2024

And for extra fun -- if I don't close the original tab and restart firefox again, then both tabs double when recovered:
Screenshot 2024-12-02 at 9 03 00 AM

(that gets super annoying super fast, when I have a dozen pull requests and github issues open in various tabs)

@scovich
Copy link
Author

scovich commented Dec 2, 2024

FYI an issue already exists for the tab-doubling problem: #2619

@scovich
Copy link
Author

scovich commented Dec 9, 2024

It's working again today. No change since Friday except a weekend passed -- I did not even restart FF. We'll see how long it lasts this time.

@achernyakevich-sc
Copy link

@scovich Could you provide a list of all Add-Ons installed in your Firefox. Maybe it somehow conflict... It is just a hypotheses but we could try.

Another way to check could be disabling all Add-Ons except MAC and checking. If it will work alone then enable Add-ons one by one and check which one will return the issue back.

@scovich
Copy link
Author

scovich commented Dec 9, 2024

@achernyakevich-sc -- I already tried that last time somebody asked: #2689 (comment)

The problem persisted even with all extensions disabled.

@scovich
Copy link
Author

scovich commented Dec 9, 2024

(extensions are listed in the issue description, along with their versions)

@scovich
Copy link
Author

scovich commented Jan 21, 2025

Update: External links have been working again normally since coming back from the holidays. Whatever the problem is, it's quite intermittent.

@achernyakevich-sc
Copy link

Hard to say what really get problem fixed. As I understand you have new Firefox (134.0.x?) and new MAC (8.2.0?). As well I ca suspect you updated your macOS.

I have checked MAC 8.2.0 release notes - nothing special that was going to fix the issue was not implemented. But maybe it is a side effect.

In any case, if the issue will not be reproducible anymore then it would be great if you will close it and show this way to other users that updating to the latest version of software has a chance to avoid this problem. :)

@scovich
Copy link
Author

scovich commented Jan 22, 2025

As I understand you have new Firefox (134.0.x?) and new MAC (8.2.0?). As well I can suspect you updated your macOS.

Yes to Firefox update (132.0.x -> 134.0.2)

Maybe to macOs update? The ticket description notes that I was on "14.7" before, and I am currently on 14.7.1 -- so there could have been an update from 14.7.0.

No to MAC, I've had 8.2.0 the whole time:
Image

if the issue will not be reproducible anymore then it would be great if you will close it

Fair enough. I can always reopen (again) if it happens again.

@scovich scovich closed this as completed Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken!
Projects
None yet
Development

No branches or pull requests

2 participants