forums/tests => use model makers #558
Conversation
There was a problem hiding this comment.
I just moved these out of __init__.py to their own file
|
Hrm... I think I'll try to work through this later today. This is pretty intense. I didn't think about the peer-review work of changing tests to use fixtures. |
|
Yeah, going forward we might want to do these in more reasonable chunks. Something like ~20 tests a week each or whatever it takes to be done in the quarter. |
apps/forums/tests/test_feeds.py
Outdated
There was a problem hiding this comment.
I'm not sure this covers the test right. It seems like the test is checking to see if for a given forum, the threads are sorted by datetime. But if there is only one thread, then it's always sorted.
Seems like we want to create a forum here. Then create a few threads with various datetimes (probably want to specify the datetimes since it's part of the test), then make sure the ThreadsFeed puts them in order correctly.
There was a problem hiding this comment.
definitely, should be more than one thread :-)
|
Yay I finished! I don't even know how many issues there were. I think some of them were benign and some were about the test itself. The latter are worth fixing. The former if you want. |
|
OK, I think that covers it ^^ |
|
I think that looks good to me. r+ |
2 participants
yay! r?