Skip to content

Conversation

@willkg
Copy link
Member

@willkg willkg commented Apr 5, 2012

I know we talked about it in the etherpad, but figured it was a good idea to give everyone a chance to comment before I push it to master.

r?

@rlr
Copy link
Contributor

rlr commented Apr 5, 2012

I think you forgot to add a file :-)

@willkg
Copy link
Member Author

willkg commented Apr 5, 2012

Oy. It must be Thursday. I never could get the hang of Thursdays.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should just take out #2 so that #1 applies to search as well.

@rlr
Copy link
Contributor

rlr commented Apr 6, 2012

Other than that, this is a great start. r+

@willkg
Copy link
Member Author

willkg commented Apr 6, 2012

Landed in d3f61ee

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants