Add cli for front page search #555
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* adds a "./manage.py essearch <query>" which spits out results to stdout which is easier to compare with other things * brings in elasticutils update that changes highlighted to _highlighted and adds _score and _type metadata
Contributor
There was a problem hiding this comment.
What do you think of adding some kind of separator between each page? /nit
Contributor
|
This is awesome! r+ with the import styling fix. |
apps/search/es_utils.py
Outdated
Contributor
There was a problem hiding this comment.
Oh, and we keep imports in alphabetical order. Sorry for the OCD :-)
* add empty line between pages * change order of imports so they're alphabetical
This makes them compliant with the webdev standards.
Member
Author
|
Fixed the imports. Should be all set now. |
Contributor
|
:-) r+! |
Member
Author
|
Landed in 76d51a2 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to stdout which is easier to compare with other things
and adds _score and _type metadata
This has no effect on the search view output for either Elastic Search or Sphinx versions of the search view. It only adds a cli for it.
The cli is kind of handy. It shows rank, score, doc type, and title. Makes it really easy to compare results for the first three pages of a front page search between different scoring systems. We could increase that to a larger number of pages if that's useful or even just keep showing results until some score threshold.
r?