645546 dashboard #522
645546 dashboard #522
Conversation
Removes categories 30, 40, and 50 from "untranslated", "immediate updates needed" and "updates needed" sections and removes counts from the All Knowledge Base Articles number. Adds "navigation articles" with category 50 articles. Adds to overview and sections below. Adds relevant tests.
There was a problem hiding this comment.
This removes articles in categories 30, 40 and 50 from the All Knowledge Base Articles total.
|
One thing that occurs to me while I'm writing comments on my own pull request: it's worth double-checking the SQL. I did some fast-and-loose copy-and-paste, but it's entirely possible that I don't really grok the nature of a "navigation article" and thus have the sql for it wrong. Having said that, it seems right. |
There was a problem hiding this comment.
I prefer this indentation style so much now :-). Much more predictable.
This one covers all the things that shouldn't be in All Docs plus it fixes the comment.
|
I went through and made changes to navigation articles and made sure they didn't show up where they don't belong anymore (they do if I am on master). The new navigation section is nice and worked as expected. Tests passing. r+ with the minor comments. |
|
I pushed a new unit test to replace the one that had a bad comment. I think that covers it. Can you do a quick r? on that new unit test? |
There was a problem hiding this comment.
This line and 157 can be deleted :-)
|
Ok. Those comments are fixed. Good to go? |
|
all good! r+ |
2 participants
r?