LL homepage design and styleguide fixes #4048
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkellydesign
changed the title
Contributor
Author
|
@akatsoulas I have merged in my most recent CSS and template work on the homepage, and the styleguide is now fixed. You had the right idea with the sass variable, but kss-node actually doesn't compile SCSS before they parse the comments for documentation, so that sass variable didn't work. I replaced it all with plain text, and it's working correctly now. I've also deployed my S3 scripts locally, so I can still publish the styleguide. This should all be good now. |
akatsoulas
approved these changes
Dec 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.