[Bug 1385087] Add firefox download button for non fx user#2911
Merged
pmac merged 2 commits intomozilla:masterfrom Aug 16, 2017
Merged
[Bug 1385087] Add firefox download button for non fx user#2911pmac merged 2 commits intomozilla:masterfrom
pmac merged 2 commits intomozilla:masterfrom
Conversation
pmac
suggested changes
Aug 16, 2017
Contributor
pmac
left a comment
pmac
left a comment
There was a problem hiding this comment.
Just one small change I think. Looks great otherwise. Nice work!
kitsune/sumo/jinja2/base.html
Outdated
| {% endfor %} | ||
|
|
||
| {# Show firefox download button to unauthenticated users only #} | ||
| {% if not user.is_authenticated() %} |
Contributor
There was a problem hiding this comment.
Should be the same logic from line 141 I think
{% if not (hide_fx_download or user.is_authenticated()) %}
Contributor
Author
|
@pmac Updated. r? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So it will show Firefox Download Button to non fx users in all pages except Firefox Landing page because it already have a download firefox button.
@pmac @bensternthal r?