[WIP] New Community Hub Stuff #2411
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitsune/bundles.py
Outdated
Contributor
Author
There was a problem hiding this comment.
These two shouldn't be here.
Contributor
Author
|
I merged in @rehandalal's django-pipeline and bower stuff. It makes things nicer and also production ready, but it unfortunately means this PR is huge and complicated right now. The commits you should be looking at here are the commits I authored, excluding the merge commit. Everything rehan authored is in one of his PRs, which I hope will land soon. Once they land, I'll rebase this to not be so crazy. |
Member
|
I would have cheated by pushing @rehandalal's branch to our master repository, then generating the PR against that. |
Contributor
Author
|
That's a really good idea. I'm going to try to do that. |
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still WIP, but I would like to get some feedback on this and if it is something we want to keep doing on other parts of the site.
Right now this relies on client side JSX compilation, which is bad. I have some work in another branch that integrates this in with django-pipeline and bower and browserify and babel and it is all complicated and unfinished and I'm going to have to write a bunch of docs about it.