Skip to content

Conversation

@mythmon
Copy link
Contributor

@mythmon mythmon commented Feb 27, 2015

There were three main issues here:

  • Lack of tests
  • Using an EmailField for the email field on the serializer.
  • Removing the idea of creating users without emails (and that they don't need validated). No one was using this.

r?

@mythmon
Copy link
Contributor Author

mythmon commented Feb 27, 2015

I did not do the good thing of unifying the validation between the views and the API and the models. Mainly because there was already pretty good validation in place in the API.

rehandalal added a commit that referenced this pull request Feb 27, 2015
[Bug 1136586] Fix validation for users api.
@rehandalal rehandalal merged commit 499e633 into mozilla:master Feb 27, 2015
@mythmon mythmon deleted the validate-profile-api-1136586 branch March 9, 2015 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants