[bug 1128477] Tags API for questions #2360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitsune/questions/api.py
Outdated
Contributor
There was a problem hiding this comment.
If you do this, it will give a 50x error if the user doesn't pass a tag. It is better to do something like in delete_metadata to check that it is the data, and if not, give a 400 bad request error. 500s are bad because the are completely opaque to users.
Contributor
|
This is looking good. I made some comments that are mostly about friendliness of the API, and consistency. I didn't test this though. |
Contributor
Author
|
Ready to go, with tests. r? |
rehandalal
changed the title
Contributor
|
r+, but this seems to have a merge conflict. Want to fix that, and merge this? |
rehandalal
added a commit
that referenced
this pull request
Feb 12, 2015
[bug 1128477] Tags API for questions
This was referenced Jul 10, 2020
This was referenced Aug 16, 2020
This was referenced Mar 22, 2022
This was referenced Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
f?