[bug 1085456] Support Forum metrics email report.

[rlr]

I wanted some feedback here before going further.

Instead of hard-coding users and email addresses, I went with two groups. The group of users to track and the group of users to send the report to. Is that cool?

If that's cool, should we create the groups in a migration? I'm pretty sure we've always created new groups in the admin, but I'm game either way.

Does this need a test? It seems like a throwaway script. I'd probably need to refactor it to make it testable. Actually, I can probably poke at the email with django's test infra.

f?

[mythmon]

I like the idea of using groups for this instead of having a hard coded list. That makes less work for us later.

Since this requires the groups to exist or else it fails, I think we should use a migration to add them (though they can be populated manually).

If it is easy to test, something like "running the cronjob sends an email" that would be cool, but I don't think it is needed, especially if it needs refactoring.

Looks good!

[rlr]

OK, writing a test was worthwhile as I found a typo/bug.

Now this is ready for r?

[mythmon]

Typo

[rlr]

fixord ^^

[mythmon]

I just realize this is probably going to look really weird in a plain text email, because it will have lots of extra space. Or does send_email deal with that?

[mythmon]

Besides the white space thing, this looks good. r+ once that is fixed.