Skip to content

[bug 911581] Add autocomplete to tag filtering on /questions. #1695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rlr wants to merge 2 commits into from
Closed

[bug 911581] Add autocomplete to tag filtering on /questions. #1695

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
210fbb5
[bug 911581] Add autocomplete to tag filtering on /questions.
rlr Oct 28, 2013
f8f48f8
fix tests
rlr Oct 28, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion kitsune/questions/templates/questions/questions.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ <h3>{{ _('Show') }}</h3>
<section id="tag-filter">
<h3>{{ _('Filter') }}</h3>
<p>{{ _('Enter a tag. For example: "Firefox 14.0", "Windows 7", "crash"') }}</p>
<form action="#" method="get">
<form method="get">
<input type="hidden" class="current-tagged" value="{{ tagged }}"/>
{% for key, value in request.GET.items() %}
<input type="hidden" name="{{ key }}" value="{{ value }}"/>
Expand Down
7 changes: 7 additions & 0 deletions kitsune/sumo/static/js/tags.filter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,13 @@ function init($container) {
}
});

// Autocomplete
$tags.autocomplete({

@mythmon mythmon Oct 28, 2013

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's it?

source: _.keys(vocab),
delay: 0,
minLength: 1
});

// When form is submitted, get the slugs to send over in request.
$form.submit(function() {
var tagNames = $tags.val(),
Expand Down