Upgrade selenium #1654
Merged
Upgrade selenium #1654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
WFM. I guess we should wait to see if it WFT (Travis). r+ once travis nods. |
Member
Author
|
I can't tell if this ever got travis'd. I don't think it did. |
I have Firefox Nightly earlier in my path than Firefox stable. Nightly has problems with Selenium that haven't been fixed, yet, (or something like that). This allows me to specify exactly which Firefox binary to use without having to fiddle with my PATH environment variable which caused other problems because of virtual environments and such. It defaults to exactly what happened before, so if it worked for you before, you should see no change with this change.
Contributor
|
The changes look good, and it runs and passes for me. OK! 1513 tests, 0 failures, 0 errors, 2 skips in 258.0s r+ from me too. I'm ok with pushing this out without Travis because of a) the outage, and b) it doesn't affect prod, because it is just a change to tests, so the risk of something going horribly wrong is low. |
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrades the version of selenium we're using and also introduces a helpful SELENIUM_FIREFOX_PATH setting which can aid in sad-path environments like mine.
r?