[bug 920470] Require SSL during entire AAQ workflow. #1650
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
There was a problem hiding this comment.
Why was this the way it was before?
Contributor
Author
There was a problem hiding this comment.
because we need to switch them to ssl before logging them in.
Member
|
This looks fine. We can fix the ssl_required thing in another PR. Looks like there are a few other places where we set |
Contributor
Author
|
I'll fix the Landed: 473b881 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is hard to manually test locally unless you have a full apache setup. I don't see what could go wrong but I'll leave it baking on stage and have kadir, qatestbot, etc test it before deploying to prod.
r?