Skip to content

[Bug 918002] Give feedback that Persona is working. #1629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mythmon merged 1 commit into from
Sep 18, 2013
Merged

[Bug 918002] Give feedback that Persona is working. #1629

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion kitsune/sumo/static/js/browserid.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,15 @@
next = $this.data('next') || document.location.pathname + document.location.search;
$form.find('input[name="next"]').val(next);

var originalText = $this.text();
$this.text(gettext('Signing you in...'));

navigator.id.request({
returnTo: next,
siteName: gettext('Mozilla Support')/*,
siteName: gettext('Mozilla Support'),
onCancel: function() {
Copy link
Contributor

@rlr rlr Sep 18, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait, according to the docs it is oncancel https://developer.mozilla.org/en-US/docs/Web/API/navigator.id.request

Copy link
Contributor Author

@mythmon mythmon Sep 18, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK! Why would they do that?

Copy link
Contributor Author

@mythmon mythmon Sep 18, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed 6723c49, which changes the case of that param.

This is actually even better now, because when the user closes the Persona window, it calls oncancel, which is kind of what I expected.

Copy link
Contributor

@rlr rlr Sep 19, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay!

$this.text(originalText);
}/*,
TODO: siteLogo: */
});
});
Expand Down