[bug 882944] Stop showing empty subtopics.

[rlr]

Swithed to use our existing topics_for() helper for listing subtopics.

r?

[rlr]

nevermind OK! 1484 tests, 0 failures, 0 errors, 5 skips in 155.4s

R+! woot

[rlr]

oh no wrong PR lol

[rlr]

r- @rlr r-

[mythmon]

I think this change to the signature is a little odd because the parent and include_subtopics parameters are really interconnected. It doesn't make a lot of sense to speicify both, but there is nothing stopping you. Sadly I can't think of a way to improve this.

[rlr]

Maybe default parent to False? and set it if it isn't False. Then kill include_subtopics?

[mythmon]

Oh, that makes sense. I was trying to think of something like that and getting caught up because my usual null value, None, was already a thing.

[rlr]

ok, i like that better ^^

[mythmon]

Nice! 😀 r+

[rlr]

1df094f