Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustc option "instrument-coverage" stabilized #790

Merged
merged 9 commits into from
Apr 13, 2022
Merged

Conversation

kazuk
Copy link
Contributor

@kazuk kazuk commented Mar 2, 2022

then change -Z to -C

see: rust-lang/rust#90132

@marco-c
Copy link
Collaborator

marco-c commented Mar 15, 2022

@kazuk it is not stable yet in the latest Rust version. We need to wait on 1.59.

@marco-c
Copy link
Collaborator

marco-c commented Mar 15, 2022

Once 1.59 is out, we can also remove mentions to RUSTC_BOOTSTRAP.

@kazuk
Copy link
Contributor Author

kazuk commented Mar 15, 2022

My understanding, grcov requires "Nightly" Rust.
So I think no need to wait "Stable" Rust 1.59.

@marco-c
Copy link
Collaborator

marco-c commented Mar 15, 2022

It is possible to use stable rust (by setting the RUSTC_BOOTSTRAP environment variable).

@marco-c
Copy link
Collaborator

marco-c commented Apr 7, 2022

@kazuk Rust 1.60 is out with support for source-based coverage instrumentation. I think we can now merge this, but first we have to remove mentions to RUSTC_BOOTSTRAP. Could you update the PR?

@kazuk
Copy link
Contributor Author

kazuk commented Apr 7, 2022

I update Usage line, and update "grcov with Travis" example.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@marco-c marco-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@marco-c marco-c merged commit db909c4 into mozilla:master Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants