Bundle bulma CSS #1086
Open
Bundle bulma CSS #1086
+27
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To support restricted or offline environments, bundle the bulma CSS with grcov instead of loading it from the jsdelivr CDN. HTML reports will now create `bulma.min.css` in the root directory and relatively reference it in all the HTML files. Fixes mozilla#1079.
lu-zero
reviewed
Aug 2, 2023
| fn make_context() -> Context { | ||
| let mut ctx = Context::new(); | ||
| let ver = std::env::var("BULMA_VERSION").map_or(BULMA_VERSION.into(), |v| v); | ||
| ctx.insert("bulma_version", &ver); |
There was a problem hiding this comment.
I'd keep this and add an env var or a feature for the bundling.
There was a problem hiding this comment.
What would be the advantages of having this environment variable instead of always bundling the CSS?
There was a problem hiding this comment.
Some people would prefer not bundling it, I guess.
There was a problem hiding this comment.
Also if you want to go the extra mile, you may add a cli option to pass the css file.
@marco-c if you are fine with the idea of bundling I can accept this patch.
|
What is required to move forward with this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support restricted or offline environments, bundle the bulma CSS with grcov instead of loading it from the jsdelivr CDN.
HTML reports will now create
bulma.min.cssin the root directory and relatively reference it in all the HTML files.Fixes #1079.
@calixteman: I don't think this is what you had in mind, but let me know what you think, I'm happy to implement/work on a different approach if that would be preferred.