Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport the InvalidOverflow error #583

Merged
merged 5 commits into from
Dec 17, 2019

Conversation

Dexterp37
Copy link
Contributor

No description provided.

This is used by the timing distribution metric type
whenever a passed sample is bigger than 10 minutes.
This also adds a small note in the
Rust code to mention that all these
things need to be updated.
@codecov-io
Copy link

codecov-io commented Dec 17, 2019

Codecov Report

Merging #583 into release-v22.1.0 will increase coverage by 0.17%.
The diff coverage is 75%.

Impacted file tree graph

@@                  Coverage Diff                  @@
##             release-v22.1.0     #583      +/-   ##
=====================================================
+ Coverage              74.79%   74.97%   +0.17%     
  Complexity               334      334              
=====================================================
  Files                    100      100              
  Lines                   5857     5859       +2     
  Branches                 741      741              
=====================================================
+ Hits                    4381     4393      +12     
+ Misses                   936      928       -8     
+ Partials                 540      538       -2
Impacted Files Coverage Δ Complexity Δ
glean-core/src/error_recording.rs 77.9% <50%> (-0.67%) 0 <0> (ø)
glean-core/src/metrics/timing_distribution.rs 69.01% <83.33%> (+7.74%) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba71ffe...1d19f14. Read the comment docs.

@Dexterp37 Dexterp37 merged commit 6c17229 into mozilla:release-v22.1.0 Dec 17, 2019
@Dexterp37 Dexterp37 deleted the release-v22.1.0 branch December 17, 2019 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants