On init and if upload is disabled, see if we need to resend a de… #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
badboy
force-pushed
the
retry-del-req
branch
2 times, most recently
from
cfddcb2 to
a1aeec4
Compare
Codecov Report
@@ Coverage Diff @@
## master #545 +/- ##
============================================
+ Coverage 74.43% 74.47% +0.04%
Complexity 334 334
============================================
Files 100 100
Lines 5886 5897 +11
Branches 745 746 +1
============================================
+ Hits 4381 4392 +11
Misses 965 965
Partials 540 540
Continue to review full report at Codecov.
|
mdboom
reviewed
Dec 4, 2019
|
There is! Let me do that. |
|
Looks like it currently already retries: https://github.com/mozilla/glean/blob/master/glean-core/android/src/main/java/mozilla/telemetry/glean/scheduler/DeletionPingUploadWorker.kt#L188 As I understand it it's tried for a total runtime of 10 minutes (unless force-stopped I guess). Just makes it a bit harder to test. |
…n request ping No new ping will be generated. It will only sent a previously-failed ping, if any.
travis79
approved these changes
Dec 5, 2019
badboy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No new ping will be generated.
It will only sent a previously-failed ping, if any.
I would block that on #539, so that I can include the necessary Python changes as well